Helm Service: Align internal to external.

[Gacko]

What this PR does / why we need it:

This PR aligns the internal service to the external one and makes the node ports of the internal one configurable separately to prevent port collisions.

It mostly adds features implemented in the normal service to the internal one since other contributors forgot to do so in their PRs. I furthermore split the existing node port config of the internal one apart from the normal one since you would get port collisions when enabling both services and pre-defining node ports otherwise.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Hi @Gacko. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[netlify]

✅ Deploy Preview for kubernetes-ingress-nginx canceled.

Name	Link
🔨 Latest commit	c6b3eb7
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/656f344cdc7d5b0008713d91

[Gacko]

@tao12345666333: I created this PR in favor of #9700 since the base repository changed.

[Gacko]

@tao12345666333: Same here as in #10238 (comment). Any reasons not to merge this? Do you need support with reviewing it?

This PR mostly adds features implemented in the normal service to the internal one since other contributors forgot to do so in their PRs. So the normal service is actually not being changed and the internal one only gets new features.

I furthermore split the existing node port config of the internal one apart from the normal one since you would get port collisions when enabling both services and pre-defining node ports otherwise.

Just reach out to me if I can support you somewhere or fasten the process of merging this PR! :)

[Gacko]

One more note: Changes in README.md are generated from values.yaml, obviously, and changes in the latter are just a copy from the external service values plus changing external to internal where necessary. So the values for the internal service are mostly just a copy of the external one.

[tao12345666333]

You don't need to update this PR, thanks!
I will take a look and have some tests.

[Gacko]

@tao12345666333 Do you need support here? Should I rebase the PR?

We have this version running in several clusters for a while now, so at least it's proven in production. I could also offer to pair on reviewing, if you want.

[Gacko]

/kind feature
/priority backlog
/triage accepted

[strongjz]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [Gacko,strongjz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment