Release v1.8.2 and Update Go to v1.21.1 #10379
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-kind
rikatz
force-pushed
the
start-182-release
branch
3 times, most recently
from
35bfca4
to
c183a70
Compare
* Bump Go version to 1.21.1 * Bump testrunner image
rikatz
force-pushed
the
start-182-release
branch
from
c183a70
to
910297f
Compare
| @@ -62,22 +62,6 @@ jobs: | |||
| - 'charts/ingress-nginx/**/*' | |||
| - 'NGINX_BASE' | |||
|
|
|||
|
|
|||
| security: | |||
There was a problem hiding this comment.
gosec is failing to build/get with v1.21.1, but I have checked with golangci-lint and "all is fine" (ish) as we didn't cherrypicked the changes made on main to update the lint problems.
I will leave this way now to move forward on this release
| @@ -712,7 +712,7 @@ type Configuration struct { | |||
|
|
|||
| // DatadogSampleRate specifies sample rate for any traces created. | |||
| // Default: use a dynamic rate instead | |||
| DatadogSampleRate *float32 `json:"datadog-sample-rate",omitempty` | |||
| DatadogSampleRate *float32 `json:"datadog-sample-rate,omitempty"` | |||
There was a problem hiding this comment.
Problem detected by linter during the execution of it manually
test/e2e/settings/ocsp/ocsp.go
Outdated
| @@ -47,6 +47,7 @@ var _ = framework.DescribeSetting("OCSP", func() { | |||
| }) | |||
|
|
|||
| ginkgo.It("should enable OCSP and contain stapling information in the connection", func() { | |||
| ginkgo.Skip("OCSP tests are failing due to bad glibc versions") | |||
There was a problem hiding this comment.
BEcause the version of testrunner is different from something here, cfssl, which is used on OCSP tests is failing.
Skipping for now, but just on this branch
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/hold some things on new Go version are failing and being tested on #10382 to be cherry picked also |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
rikatz
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, strongjz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Starts the v1.8.2 release, bumping Go v1.21.1