Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http default backend test #10382

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Sep 8, 2023

The default backend test is failing because we are passing space on the beginning of header and apparently go v1.21 blocks this now

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2023
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit 0a03f10
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/64fa7d0264466500099d8833

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@rikatz rikatz added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit e5f5242 into kubernetes:main Sep 8, 2023
44 checks passed
@rikatz
Copy link
Contributor Author

rikatz commented Sep 8, 2023

/cherrypick release-1.8

@k8s-infra-cherrypick-robot
Copy link
Contributor

@rikatz: #10382 failed to apply on top of branch "release-1.8":

Applying: Fix http default backend test
Using index info to reconstruct a base tree...
M	.github/workflows/ci.yaml
M	test/e2e/settings/ocsp/ocsp.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/settings/ocsp/ocsp.go
Auto-merging .github/workflows/ci.yaml
CONFLICT (content): Merge conflict in .github/workflows/ci.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix http default backend test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rikatz added a commit to rikatz/ingress-nginx that referenced this pull request Sep 8, 2023
k8s-ci-robot pushed a commit that referenced this pull request Sep 8, 2023
* Bump Go version to 1.21.1 (#10377)

* Bump Go version to 1.21.1

* Bump testrunner image

* Fix lint error on datadog struct

* Revert lint on 1.8

* Fix http default backend test

* Fix http default backend test

* Fix http default backend test (#10382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants