-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modsecurity module #1498
Add modsecurity module #1498
Conversation
06170ca
to
3f19664
Compare
3f19664
to
b44fe56
Compare
b44fe56
to
0447484
Compare
0447484
to
a03d6eb
Compare
a03d6eb
to
2d23c51
Compare
2d23c51
to
a9a22b0
Compare
images/nginx-slim/build.sh
Outdated
--add-module=$BUILD_PATH/nginx-opentracing-$NGINX_OPENTRACING" | ||
|
||
if [[ ${ARCH} == "x86_64" ]]; then | ||
WITH_MODULES+=" --add-module=$BUILD_PATH/ModSecurity-nginx-$MODSECURITY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf I would only like to ask if that's possible for us to use --add-dynamic-module instead of --add-module, so NGINX creates a .so file, that could be loaded in runtime, allowing us to load this module only if the user want's this :)
Here are some examples, this is supported in NGINX community since version 1.9.11 and may use an absolute path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@nicksardo please merge and publish. Thanks! |
What this PR does / why we need it:
This PR adds the ModSecurity-nginx module to the nginx-slim image.