Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial version of HAProxy controller #214

Closed
wants to merge 1 commit into from

Conversation

jcmoraisjr
Copy link
Contributor

A very first, but fully functional, initial version of HAProxy controller.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@bprashanth
Copy link
Contributor

I think haproxy is popular enough that we can take this, but in general I want to push users to keeping controllers in their tree, though, per: https://github.com/kubernetes/ingress/tree/master/docs/faq#how-do-i-contribute-a-backend-to-the-generic-ingress-controller

@bprashanth
Copy link
Contributor

People will surely ask for caddy and/or envoy next. I'm on the fence, where do we draw the line? @jcmoraisjr how hard would it be to maintain this in your tree and add examples, as indicated in the faq linked above.

@jcmoraisjr
Copy link
Contributor Author

jcmoraisjr commented Feb 3, 2017

@bprashanth I read the faq a while ago and really missed the how to contribute a backend part, sorry. No problem, I think I can maintain this controller in my own fork and update some common pages here as you have indicated.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 44.249% when pulling 5f73b61 on jcmoraisjr:jm-haproxy into 1cebef2 on kubernetes:master.

@bprashanth
Copy link
Contributor

Thanks so much for the pr!
Please link into https://github.com/kubernetes/ingress/blob/master/docs/catalog.md and add examples, since a lot of people have asked for a haproxy controller. I've filed #215 and I'm closing this for now. You shouldn't need to fork, just vendor ingress as a godep?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants