Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply nginx patch to make ssl_certificate_by_lua_block work properly #3006

Merged
merged 1 commit into from
Aug 29, 2018
Merged

apply nginx patch to make ssl_certificate_by_lua_block work properly #3006

merged 1 commit into from
Aug 29, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
As documented at https://github.com/openresty/lua-nginx-module#ssl_certificate_by_lua_block this patch (http://mailman.nginx.org/pipermail/nginx-devel/2016-January/007748.html) is needed for ssl_certificate_by_lua_block to work properly.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 29, 2018
@ElvinEfendi
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2018
@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #3006 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3006   +/-   ##
=======================================
  Coverage   47.54%   47.54%           
=======================================
  Files          77       77           
  Lines        5639     5639           
=======================================
  Hits         2681     2681           
  Misses       2605     2605           
  Partials      353      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355b793...0408d66. Read the comment docs.

@ElvinEfendi
Copy link
Member Author

/hold cancel
/assign @aledbf

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2018
@aledbf
Copy link
Member

aledbf commented Aug 29, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 91eecde into kubernetes:master Aug 29, 2018
@ElvinEfendi ElvinEfendi deleted the nginx-patch-for-cert-by-lua branch August 29, 2018 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants