Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openresty and third party modules #4509

Merged
merged 2 commits into from
Sep 4, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 29, 2019

What this PR does / why we need it:

This PR also adds mimalloc https://github.com/microsoft/mimalloc/pulls as a drop-in replacement for malloc. This is not enabled or used by default but the gains could be better than using jemalloc.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2019
set -o errexit
set -o nounset
set -o pipefail

export DEBIAN_FRONTEND=noninteractive

export OPENRESTY_VERSION=1.15.8.2
export OPENRESTY_VERSION=1.15.8.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are you downgrading?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there's no 1.15.8.2 release in the openresty page.

Copy link
Member

@ElvinEfendi ElvinEfendi Sep 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm, https://openresty.org/download/openresty-1.15.8.2.tar.gz is available though and should introduce the latest CVE patches

it's released in https://github.com/openresty/openresty/releases/tag/v1.15.8.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that tgz does not contains all the packages and when I tried to use it I got lots of errors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I am waiting for a 1.17 release before continuing with this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting, maybe @thibaultcha can comment on this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tarball is now available at https://openresty.org/download/openresty-1.15.8.2.tar.gz. It took some time since only agentzh can upload them to openresty.org at the moment, and he was travelling when 1.15.8.2 was released. It is the same as the GitHub release tarball I uploaded a few days ago already!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibaultcha thanks for the update.

@codecov-io
Copy link

codecov-io commented Sep 1, 2019

Codecov Report

Merging #4509 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4509      +/-   ##
==========================================
+ Coverage   59.05%   59.08%   +0.02%     
==========================================
  Files          89       89              
  Lines        6811     6811              
==========================================
+ Hits         4022     4024       +2     
+ Misses       2350     2349       -1     
+ Partials      439      438       -1
Impacted Files Coverage Δ
internal/ingress/metric/collectors/process.go 90.42% <0%> (+2.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74031cc...66516cf. Read the comment docs.

@aledbf aledbf removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2019
@aledbf aledbf changed the title WIP: Update openresty and third party modules Update openresty and third party modules Sep 4, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2019
@aledbf aledbf force-pushed the nginx branch 4 times, most recently from 2af7ded to 66516cf Compare September 4, 2019 14:17
@@ -525,10 +539,13 @@ apt-get remove -y --purge \
python \
xz-utils \
bc \
sensible-utils \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we introducing this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that is being removed 😛
It's a transitive dependency not removed by the autoremove

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b4ab6f3 into kubernetes:master Sep 4, 2019
@aledbf aledbf deleted the nginx branch September 4, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants