Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ports collision when hostNetwork=true #4617

Merged
merged 1 commit into from
Sep 28, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 28, 2019

What this PR does / why we need it:

The ports for the lua configuration of HTTP and TCP/UDP should not use ports already defined in Kubernetes. This PR also introduces two flags to allow different port values.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #4616

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2019
@codecov-io
Copy link

codecov-io commented Sep 28, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9ecec0d). Click here to learn what that means.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4617   +/-   ##
=========================================
  Coverage          ?   58.68%           
=========================================
  Files             ?       88           
  Lines             ?     6763           
  Branches          ?        0           
=========================================
  Hits              ?     3969           
  Misses            ?     2355           
  Partials          ?      439
Impacted Files Coverage Δ
cmd/nginx/main.go 6.53% <0%> (ø)
internal/ingress/controller/controller.go 50.55% <0%> (ø)
cmd/nginx/flags.go 86.66% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ecec0d...e0441a5. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2019
@aledbf aledbf merged commit d5d2b40 into kubernetes:master Sep 28, 2019
@aledbf aledbf deleted the port-collision branch September 29, 2019 17:44
towolf pushed a commit to towolf/ingress-nginx that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bind() to 127.0.0.1:10256 failed (98: Address already in use)
3 participants