Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect for app-root should preserve current scheme #5266

Merged
merged 1 commit into from
Mar 19, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 18, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #5261

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2020
@aledbf
Copy link
Member Author

aledbf commented Mar 19, 2020

/test pull-ingress-nginx-test

@codecov-io
Copy link

Codecov Report

Merging #5266 into master will increase coverage by 0.02%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5266      +/-   ##
==========================================
+ Coverage   58.58%   58.61%   +0.02%     
==========================================
  Files          88       88              
  Lines        6879     6893      +14     
==========================================
+ Hits         4030     4040      +10     
- Misses       2407     2410       +3     
- Partials      442      443       +1     
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 80.08% <0.00%> (ø)
internal/ingress/annotations/rewrite/main.go 51.11% <60.00%> (+2.72%) ⬆️
internal/ingress/metric/collectors/process.go 90.62% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bbdaa...9d4e904. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Mar 19, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Mar 19, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Mar 19, 2020

/test pull-ingress-nginx-e2e-1-15

@aledbf aledbf merged commit 07b70f6 into kubernetes:master Mar 19, 2020
@aledbf aledbf deleted the app-root branch March 19, 2020 22:55
towolf pushed a commit to towolf/ingress-nginx that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ingress-nginx with app-root and force-ssl-redirect is redirecting to http firstly even I call https
3 participants