-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "Development" from Welcome page #7150
Remove "Development" from Welcome page #7150
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @moijes12! |
Hi @moijes12. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can link it to https://kubernetes.github.io/ingress-nginx/developer-guide/getting-started/
@tao12345666333 That's a completely different page and the section is available anyways. So I was thinking the "Development" section in "Welcome" should now be considered redundant and therefore should be removed. |
The cncf-cla has been signed. /assign @ElvinEfendi |
/ok-to-test |
Good catch, thanks! |
/check-cla |
@moijes12 please make sure the email you used in your commit is the same one that you signed the CLA :) Will wait to see if bot can find the signed CLA again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
/lgtm
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404. We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it. The cla has been signed.
6fc05e1
to
21996f4
Compare
/check-cla |
I signed it |
/check-cla |
1 similar comment
/check-cla |
@rikatz @tokers @tao12345666333 Please can you add the "lgtm" label again if you are ok with it |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: moijes12, rikatz, tao12345666333, tokers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404. We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it. The cla has been signed.
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404. We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it. The cla has been signed.
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404. We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it. The cla has been signed.
What this PR does / why we need it:
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404. We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it.
Types of changes
Checklist: