Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Development" from Welcome page #7150

Merged

Conversation

moijes12
Copy link
Contributor

What this PR does / why we need it:

The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404. We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @moijes12!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @moijes12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 21, 2021
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moijes12
Copy link
Contributor Author

moijes12 commented May 21, 2021

@tao12345666333 That's a completely different page and the section is available anyways. So I was thinking the "Development" section in "Welcome" should now be considered redundant and therefore should be removed.

@moijes12
Copy link
Contributor Author

The cncf-cla has been signed.

/assign @ElvinEfendi

@rikatz
Copy link
Contributor

rikatz commented May 23, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 23, 2021
@rikatz
Copy link
Contributor

rikatz commented May 23, 2021

Good catch, thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2021
@rikatz
Copy link
Contributor

rikatz commented May 23, 2021

/check-cla

@rikatz
Copy link
Contributor

rikatz commented May 23, 2021

@moijes12 please make sure the email you used in your commit is the same one that you signed the CLA :)

Will wait to see if bot can find the signed CLA again

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

/lgtm

The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404.

We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it.
The cla has been signed.
@moijes12 moijes12 force-pushed the remove-development-from-welcome-page branch from 6fc05e1 to 21996f4 Compare May 23, 2021 03:30
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2021
@tao12345666333
Copy link
Member

/check-cla

@moijes12
Copy link
Contributor Author

I signed it

@rikatz
Copy link
Contributor

rikatz commented May 23, 2021

/check-cla

1 similar comment
@moijes12
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 23, 2021
@moijes12
Copy link
Contributor Author

moijes12 commented May 23, 2021

@rikatz @tokers @tao12345666333 Please can you add the "lgtm" label again if you are ok with it

@rikatz
Copy link
Contributor

rikatz commented May 23, 2021

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moijes12, rikatz, tao12345666333, tokers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f7cba24 into kubernetes:master May 23, 2021
@moijes12 moijes12 deleted the remove-development-from-welcome-page branch May 23, 2021 14:01
carnei-ro pushed a commit to carnei-ro/ingress-nginx that referenced this pull request Jun 7, 2021
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404.

We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it.
The cla has been signed.
qiqizjl pushed a commit to qiqizjl/ingress-nginx that referenced this pull request Jul 7, 2021
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404.

We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it.
The cla has been signed.
zhaogaolong pushed a commit to zhaogaolong/ingress-nginx that referenced this pull request Oct 8, 2021
The development.md file does not exist. Clicking on "Development" link on the Welcome page returns a 404.

We already have a Developer Guide. Having the Development page should not be required. Hence, I am proposing that we remove it.
The cla has been signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants