-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add newline indenting to admission webhook annotations #8015
Add newline indenting to admission webhook annotations #8015
Conversation
Signed-off-by: Alex Sears <me@alexsears.com>
@searsaw: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @searsaw! |
Hi @searsaw. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @ChiefAlexander |
Thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, iamNoah1, searsaw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Alex Sears <me@alexsears.com>
This PR updates the
indent
function used in the annotations for the admission webhook jobs to usenindent
instead to fix YAML structure issues.What this PR does / why we need it:
This fixes YAML structure issues that prevent YAML to JSON conversion when deploying the chart when adding annotations via
controller.admissionWebhooks.annotations
.Types of changes
How Has This Been Tested?
Simply ran
helm template
with a values file that has the annotations added.The following command shows the issue:
Checklist: