Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7271 feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 #8155

Merged
merged 5 commits into from
Jan 17, 2022
Merged

#7271 feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 #8155

merged 5 commits into from
Jan 17, 2022

Conversation

marcportabellaclotet-mt
Copy link
Contributor

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

Pod disruption budgets should not be created when default-backend deployment creation is set to disabled and default backend replicas are set to more than 1.

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot
Copy link
Contributor

@marcportabellaclotet-mt: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @marcportabellaclotet-mt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/helm Issues or PRs related to helm charts labels Jan 17, 2022
@marcportabellaclotet-mt marcportabellaclotet-mt mentioned this pull request Jan 17, 2022
Closed
8 tasks
@marcportabellaclotet-mt
Copy link
Contributor Author

/assign @rikatz

@marcportabellaclotet-mt marcportabellaclotet-mt changed the title #7271 db pdb unneeded creation v2 #7271 feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1 Jan 17, 2022
@k8s-triage-robot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-contributor-experience at kubernetes/community.

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 17, 2022
@rikatz
Copy link
Contributor

rikatz commented Jan 17, 2022

/ok-to-test
/lgtm
/approve
Thanks!

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marcportabellaclotet-mt, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4badf20 into kubernetes:main Jan 17, 2022
@marcportabellaclotet-mt marcportabellaclotet-mt deleted the #7271-db-pdb-unneeded-creation-v2 branch January 18, 2022 08:27
@tao12345666333 tao12345666333 mentioned this pull request Feb 27, 2022
Closed
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@marcportabellaclotet-mt @rchshld
kubernetes#7271 feat: avoid-pdb-creation-when-default-backend-disable…
099ecad 
…d-and-replicas-gt-1 (kubernetes#8155)

* feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1

* fix: added-eol

* feat: avoid-pdb-creation-when-default-backend-disabled-and-replicas-gt-1

* fix: added-eol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChiefAlexander ChiefAlexander Awaiting requested review from ChiefAlexander

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marcportabellaclotet-mt @k8s-ci-robot @k8s-triage-robot @rikatz