-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding annotations to the controller service account #8173
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @bwlkr! |
Hi @bwlkr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ChiefAlexander |
@bwlkr Thank you for your contribution. It helps. This seems like ready to merge except that there is no info on the history, context and safety of the change. My suggestion would be ;
Once above 2 aspects are taken care of, then this is good to merge I feel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/kind bug
/triage accepted
/priority important-soon
Thanks @longwuyuan, as requested I've raised an issue to add context. Below are screenshots of values used: And the generated helm template for the controller service account: Once applied I can exec onto a controller pod and see the correct env variables populated from the above eks annotation.
|
/ok-to-test Thanks for the contribution. It helps |
/kind feature |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bwlkr, longwuyuan, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix: adding annotations to the controller service account * fix: adding annotations to the controller service account
What this PR does / why we need it:
Adds the ability to annotate the controller service account. This is particularly useful when using IRSA on AWS.
Types of changes
Which issue/s this PR fixes
Ability to annotate the controller service account, this could be viewed as new functionality but as its such a small change and was part of the deprecated nginx helm chart I've put it as a fix.
How Has This Been Tested?
Tested changes with updated values file, everything deployed successfully with the service account annotations being provisioned correctly.
Checklist: