support extraEnvs for job resources in helm chart

[Eric84626]

Signed-off-by: Li, Eric Xiannan.li@fmr.com

Support for an controller.admissionWebhooks.extraEnvs value in the Helm chart.

Which issue/s this PR fixes

fixes #8395

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Eric84626 (f051ee0, 4a7981e, 1c43936, 153a927)

[k8s-ci-robot]

@Eric84626: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @Eric84626!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Eric84626. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Eric84626]

Hello @ChiefAlexander @cpanato ,
Would you help to review this PR?

Best regards

[longwuyuan]

@vdboor and @Eric84626 I am curious to understand and clarify something.

The helm chart is generic
The Azure install recommendation is this manifest https://kubernetes.github.io/ingress-nginx/deploy/#azure
That manifest is essentially a link to https://github.com/kubernetes/ingress-nginx/blob/main/deploy/static/provider/cloud/deploy.yaml
Putting provider specific configuration into the generic helm chart impacts all users who may not be on Azure
Are you still keen on changing the generic helm chart in the above context
This could be an improvement for Azure but it also sets a precedent that we will start adding provider specific config in generic artifact like generic helm chart. If all users of all providers start adding all provider specific config in the generic helm chart, it could cause problems that are not foreseen
Since you already have a customised solution, do you know if that is enough to solve the use-case problem of configuring AZURE variable for FQDN

Also, of-course we can wait and see what others feel about such changes

[cpanato]

is it possible to add some test data in the ci directory to test this?

[Eric84626]

Thanks for your comment, @cpanato .
I have added some test data in the ci directory as your comment.

[Eric84626]

Hello @ChiefAlexander @cpanato ,
Would you help to review this PR?

[cpanato]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Eric84626

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/ingress-nginx/OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[strongjz]

The helm chart version was not bumped, so this didn't get released. https://github.com/kubernetes/ingress-nginx/runs/6986422256?check_suite_focus=true#step:4:50

@Eric84626 can you open a new PR updating the Chart version

Update the changelog

https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/CHANGELOG.md

Then update the Chart.yaml with the version bump to 4.1.5 and the change log

https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/Chart.yaml#L5

[Eric84626]

Hello @strongjz ,
I have created another PR #8724, and dumped chart version to 4.1.5, please review that.