Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to disable server_tokens directive #94

Merged
merged 1 commit into from
Jan 12, 2017
Merged

Add support to disable server_tokens directive #94

merged 1 commit into from
Jan 12, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 29, 2016

fixes #70

@aledbf aledbf self-assigned this Dec 29, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 29, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.771% when pulling 20bf579 on aledbf:server-tokens into 8e90fc0 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.733% when pulling af9375a on aledbf:server-tokens into 567fa3b on kubernetes:master.

@aledbf aledbf mentioned this pull request Jan 5, 2017
Closed
@justinsb
Copy link
Member

LGTM!

@justinsb
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

@justinsb: you can't LGTM a PR unless you are an assignee.

In response to this comment:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justinsb justinsb self-assigned this Jan 12, 2017
@justinsb justinsb self-assigned this Jan 12, 2017
@justinsb
Copy link
Member

/lgtm

@aledbf aledbf removed their assignment Jan 12, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2017
@aledbf aledbf merged commit 54d9762 into kubernetes:master Jan 12, 2017
@aledbf aledbf deleted the server-tokens branch January 13, 2017 11:47
@rikatz
Copy link
Contributor

rikatz commented Jan 14, 2017

Guys, reviewing this, I think that this option is missing in docs.

https://github.com/kubernetes/ingress/blob/master/controllers/nginx/configuration.md

Thanks!

@aledbf
Copy link
Member Author

aledbf commented Jan 14, 2017

@rikatz #130

@klausenbusk
Copy link

Is there any particular reason why this was made opt-out instead of opt-in?

@aledbf
Copy link
Member Author

aledbf commented May 28, 2018

@klausenbusk to preserve the nginx default

hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this pull request Aug 9, 2018
@ElvinEfendi
Merge pull request kubernetes#94 from Shopify/sync-upstream
9e28c61 
Sync upstream
@nithril nithril mentioned this pull request Sep 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@justinsb justinsb

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nginx: support hiding version number (server_tokens off;) ?
7 participants
@aledbf @k8s-reviewable @coveralls @justinsb @k8s-ci-robot @rikatz @klausenbusk