Skip to content

Commit

Permalink
groups: update root OWNERS
Browse files Browse the repository at this point in the history
specifically

- drop comment about delegated approval now that we're doing it
- add nikhita and ameukam such that set of approvers is equal to
  union of sig-contribex TLs and wg-k8s-infra leads
  • Loading branch information
spiffxp committed Sep 13, 2021
1 parent bd29ba6 commit a2c8773
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
11 changes: 2 additions & 9 deletions groups/OWNERS
Original file line number Diff line number Diff line change
@@ -1,25 +1,18 @@
# See the OWNERS docs at https://go.k8s.io/owners

# approval is restricted to members of k8s-infra-group-admins@
# root approval is restricted to members of k8s-infra-group-admins@
# because they have the ability to manually run, troubleshoot, and undo
# changes
#
# approval will not be delegated to deeper directories until sufficient
# checks are in place (via testing or policy enforcement) to ensure that
# someone can't escalate privileges or create arbitrary groups
#
# ref: https://github.com/kubernetes/k8s.io/issues/460#issuecomment-849958721

options:
no_parent_owners: true

approvers:
- ameukam
- cblecker
- dims
- thockin
- spiffxp

reviewers:
- nikhita

labels:
Expand Down
2 changes: 2 additions & 0 deletions groups/groups_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,10 @@ func TestHardcodedGroupsForParanoia(t *testing.T) {
"thockin@google.com",
},
"k8s-infra-group-admins@kubernetes.io": []string{
"ameukam@gmail.com",
"cblecker@gmail.com",
"davanum@gmail.com",
"nikhitaraghunath@gmail.com",
"spiffxp@google.com",
"thockin@google.com",
},
Expand Down
2 changes: 2 additions & 0 deletions groups/wg-k8s-infra/groups.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ groups:
settings:
ReconcileMembers: "true"
members:
- ameukam@gmail.com
- cblecker@gmail.com
- davanum@gmail.com
- spiffxp@google.com
- nikhitaraghunath@gmail.com
- thockin@google.com

0 comments on commit a2c8773

Please sign in to comment.