Apply comments made on the original PR #4438

kubernetes · Mar 17, 2023 · de9e9ea · de9e9ea
1 parent 652fd6f
commit de9e9ea
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/registry.k8s.io/images/k8s-staging-autoscaling/add-version.sh b/registry.k8s.io/images/k8s-staging-autoscaling/add-version.sh
@@ -20,7 +20,10 @@
 # empty diff in such a case.
 # NOTE: Only modifies local files, does not create a PR.
 
-if [ "$2". == . ] || [ "$3". != . ]
+set +o errexit
+set -o pipefail
+
+if [ $# -ne 2 ]
 then
   echo "Usage: $0 <component name> <version tag>"
   echo "example usages:"
@@ -34,7 +37,6 @@ COMPONENT="$1"
 VERSION="$2"
 
 component_len=${#COMPONENT}
-should_read=1
 
 function emit_new_sha {
   sha=$(gcloud container images describe "gcr.io/k8s-staging-autoscaling/${component}:${VERSION}" '--format=value(image_summary.digest)' 2>/dev/null)
@@ -83,6 +85,8 @@ function handle_component {
   fi
 }
 
+should_read=1
+
 while true
 do
   if [ "$should_read" -gt 0 ]