Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GSuite Groups Reconciler Application #3356

Open
upodroid opened this issue Feb 4, 2022 · 3 comments
Open

Refactor GSuite Groups Reconciler Application #3356

upodroid opened this issue Feb 4, 2022 · 3 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.

Comments

@upodroid
Copy link
Member

upodroid commented Feb 4, 2022

Hello

I'm a contributor with Knative and we have implemented the GSuite Groups Reconciler at knative/community#905. However, this package has hardcoded references to kubernetes.io, critical validation is done go test instead of a cli sub command which forced us to clone the code and replace k8s specific references instead of go install k8s.io/k8s.io/groups@v0.0.0-20220124221514-b894a331a999.

I'm proposing:

  • groups validate command - equivalent to make test
  • groups plan command - equivalent to make run
  • groups apply command - equivalent to make run -- --confirm
  • Make the domain configurable through config.yaml

Thank you

/cc @dims @dprotaso

@upodroid upodroid added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Feb 4, 2022
@dims
Copy link
Member

dims commented Feb 4, 2022

@upodroid sounds like the right thing to do. Hoping these are minimal changes since we have a bunch of things we'll need to fix and this is already "production" code for us.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 5, 2022
@dprotaso
Copy link

dprotaso commented May 5, 2022

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants