Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build-image: Promote kube-cross:v1.14.6-1 and v1.13.14-1 #1037

Merged
merged 1 commit into from
Jul 17, 2020
Merged

build-image: Promote kube-cross:v1.14.6-1 and v1.13.14-1 #1037

merged 1 commit into from
Jul 17, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jul 17, 2020 •
edited

Promotion PR for kubernetes/release#1415, kubernetes/release#1410.

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @dims @cblecker @BenTheElder @listx @saschagrunert
cc: @kubernetes/release-engineering

@justaugustus
build-image: Promote kube-cross:v1.14.6-1 and v1.13.14-1
7cc2d46 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra labels Jul 17, 2020
markjacksonfishing
markjacksonfishing approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, markyjackson-taulia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab1728d into kubernetes:master Jul 17, 2020
@mkumatag mkumatag mentioned this pull request Jul 17, 2020
Closed
18 tasks
@justaugustus justaugustus mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markjacksonfishing markjacksonfishing markjacksonfishing approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@saschagrunert saschagrunert

@listx listx

@BenTheElder BenTheElder

@cblecker cblecker

@markjacksonfishing markjacksonfishing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@justaugustus @k8s-ci-robot @markjacksonfishing @dims @saschagrunert @listx @BenTheElder @cblecker