-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
groups: Add Jeremy Rickard as a SIG Release Technical Lead #1529
Conversation
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hasheddan -- A few nits + let's add @jeremyrickard as an owner for release-team@kubernetes.io as well.
There are a few of us in @kubernetes/sig-release-leads that hold multiple roles...
Yourself, @saschagrunert, and I are:
- SIG leadership
- Release Managers
- RelEng subproject owners
We need to codify this somewhere, but I've been roughly going by these rules:
- All SIG Release leadership should have (owner-level) access to moderate contact-only Google Groups (roughly everything that isn't prepended with
k8s-
) - Only Release Managers and RelEng subproject owners should be on groups that grant IAM to GCP
- Only RelEng subproject owners should be on
k8s-infra-release-admins
/hold
/retitle groups: Add Jeremy Rickard as a SIG Release Technical Lead
OWNERS_ALIASES
Outdated
@@ -222,6 +223,7 @@ aliases: | |||
- feiskyer # Release Manager | |||
- hasheddan # subproject owner / Release Manager / SIG Technical Lead | |||
- idealhack # Release Manager | |||
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead | |
- jeremyrickard # SIG Technical Lead |
OWNERS_ALIASES
Outdated
@@ -233,6 +235,7 @@ aliases: | |||
- feiskyer # Release Manager | |||
- hasheddan # subproject owner / Release Manager / SIG Technical Lead | |||
- idealhack # Release Manager | |||
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead | |
- jeremyrickard # SIG Technical Lead |
groups/sig-release/groups.yaml
Outdated
@@ -62,6 +63,7 @@ groups: | |||
- feiskyer@gmail.com | |||
- georgedanielmangum@gmail.com | |||
- idealhack@gmail.com | |||
- jeremy.r.rickard@gmail.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop.
groups/sig-release/groups.yaml
Outdated
@@ -45,6 +45,7 @@ groups: | |||
ReconcileMembers: "true" | |||
members: | |||
- georgedanielmangum@gmail.com | |||
- jeremy.r.rickard@gmail.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop.
Adds jeremyrickard to sig-release-leads in OWNERS_ALIASES as part of technical lead onboarding. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds jeremyrickard to appropriate sig-release groups as part of technical lead onboarding. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
4a19bf6
to
4602df5
Compare
@justaugustus updates made 👍 |
Awesome, thanks @hasheddan! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Adds @jeremyrickard to appropriate groups and OWNERS as part of sig technical lead onboarding.
(Note: Jeremy was already in the general
leads
group so he is not added in this PR)xref: kubernetes/sig-release#1421
/hold
/assign @justaugustus @saschagrunert