Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: Add Jeremy Rickard as a SIG Release Technical Lead #1529

Merged
merged 2 commits into from
Jan 15, 2021

Conversation

hasheddan
Copy link
Contributor

Adds @jeremyrickard to appropriate groups and OWNERS as part of sig technical lead onboarding.

(Note: Jeremy was already in the general leads group so he is not added in this PR)

xref: kubernetes/sig-release#1421

/hold
/assign @justaugustus @saschagrunert

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra labels Jan 14, 2021
@dims
Copy link
Member

dims commented Jan 14, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hasheddan -- A few nits + let's add @jeremyrickard as an owner for release-team@kubernetes.io as well.

There are a few of us in @kubernetes/sig-release-leads that hold multiple roles...
Yourself, @saschagrunert, and I are:

  • SIG leadership
  • Release Managers
  • RelEng subproject owners

We need to codify this somewhere, but I've been roughly going by these rules:

  • All SIG Release leadership should have (owner-level) access to moderate contact-only Google Groups (roughly everything that isn't prepended with k8s-)
  • Only Release Managers and RelEng subproject owners should be on groups that grant IAM to GCP
  • Only RelEng subproject owners should be on k8s-infra-release-admins

/hold
/retitle groups: Add Jeremy Rickard as a SIG Release Technical Lead

OWNERS_ALIASES Outdated
@@ -222,6 +223,7 @@ aliases:
- feiskyer # Release Manager
- hasheddan # subproject owner / Release Manager / SIG Technical Lead
- idealhack # Release Manager
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead
- jeremyrickard # SIG Technical Lead

OWNERS_ALIASES Outdated
@@ -233,6 +235,7 @@ aliases:
- feiskyer # Release Manager
- hasheddan # subproject owner / Release Manager / SIG Technical Lead
- idealhack # Release Manager
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- jeremyrickard # subproject owner / Release Manager / SIG Technical Lead
- jeremyrickard # SIG Technical Lead

@@ -62,6 +63,7 @@ groups:
- feiskyer@gmail.com
- georgedanielmangum@gmail.com
- idealhack@gmail.com
- jeremy.r.rickard@gmail.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop.

@@ -45,6 +45,7 @@ groups:
ReconcileMembers: "true"
members:
- georgedanielmangum@gmail.com
- jeremy.r.rickard@gmail.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop.

@k8s-ci-robot k8s-ci-robot changed the title Add jeremyrickard as sig-release technical lead groups: Add Jeremy Rickard as a SIG Release Technical Lead Jan 14, 2021
Adds jeremyrickard to sig-release-leads in OWNERS_ALIASES as part of
technical lead onboarding.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Adds jeremyrickard to appropriate sig-release groups as part of
technical lead onboarding.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 15, 2021
@hasheddan
Copy link
Contributor Author

@justaugustus updates made 👍

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 15, 2021
@justaugustus
Copy link
Member

Awesome, thanks @hasheddan!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5c9e83b into kubernetes:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants