Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups: shard some group definitions to subdirectories #2675

Merged
merged 34 commits into from Sep 8, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 8, 2021

Related:

The actual group moves are broken down mostly one-group-per-commit with the exception of k8s-infra-concorm-*, k8s-infra-staging-cluster-api-* and k8s-infra-staging-capi-*. I'll edit the description to summarize.

This is being done to prepare for delegation of group approval authority. Something living in root groups.yaml should be a very rare exception, and root group approvers should only really get notified of group additions or removals, to make sure the name is in line with policy.

This is part 1 of N, I'm trying to avoid a difficult-to-rebase PR hanging out while people add more groups or change memberships.

$ git log --pretty=oneline | grep "groups: mv" | awk '{print "- `" $6 "/groups.yaml` now contains: `" $4 "`"}' | sort
  • committee-steering/groups.yaml now contains: election
  • sig-architecture/groups.yaml now contains: k8s-infra-code-organization
  • sig-architecture/groups.yaml now contains: k8s-infra-conform-*
  • sig-architecture/groups.yaml now contains: k8s-infra-staging-apisnoop
  • sig-autoscaling/groups.yaml now contains: k8s-infra-staging-autoscaling
  • sig-cluster-lifecycle/groups.yaml now contains: k8s-infra-staging-addon-manager
  • sig-cluster-lifecycle/groups.yaml now contains: k8s-infra-staging-capi-*
  • sig-cluster-lifecycle/groups.yaml now contains: k8s-infra-staging-cluster-addons
  • sig-cluster-lifecycle/groups.yaml now contains: k8s-infra-staging-cluster-api-*
  • sig-contributor-experience/groups.yaml now contains: github
  • sig-contributor-experience/groups.yaml now contains: k8s-infra-rbac-slack-infra
  • sig-contributor-experience/groups.yaml now contains: moderators
  • sig-docs/groups.yaml now contains: blog
  • sig-docs/groups.yaml now contains: k8s-staging-sig-docs
  • sig-network/groups.yaml now contains: k8s-infra-push-cni
  • sig-node/groups.yaml now contains: k8s-infra-push-cri-tools
  • sig-release/groups.yaml now contains: k8s-infra-rbac-publishing-bot
  • sig-scalability/groups.yaml now contains: k8s-infra-rbac-perdash
  • sig-scalability/groups.yaml now contains: k8s-infra-rbac-triageparty-scalability
  • sig-scalability/groups.yaml now contains: k8s-infra-sig-scalability-oncall
  • sig-storage/groups.yaml now contains: k8s-infra-push-csi
  • sig-storage/groups.yaml now contains: k8s-staging-sig-storage
  • wg-k8s-infra/groups.yaml now contains: k8s-infra-artifact-admins
  • wg-k8s-infra/groups.yaml now contains: k8s-infra-bigquery-admins
  • wg-k8s-infra/groups.yaml now contains: k8s-infra-dns-admins
  • wg-k8s-infra/groups.yaml now contains: k8s-infra-gcs-access-logs
  • wg-k8s-infra/groups.yaml now contains: k8s-infra-rbac-cert-manager
  • wg-k8s-infra/groups.yaml now contains: k8s-infra-rbac-k8s-io-canary
  • wg-k8s-infra/groups.yaml now contains: k8s-infra-rbac-k8s-io-prod

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 8, 2021

/cc @dims @ameukam
/cc @cblecker @nikhita

@ameukam
Copy link
Member

ameukam commented Sep 8, 2021

/lgtm
/hold
If others want to comment.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 8, 2021

I'm going to /hold cancel in an hour or so, none of these changes are irreversible if there are post-merge review comments.

@dims
Copy link
Member

dims commented Sep 8, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@parispittman
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 59ee351 into kubernetes:main Sep 8, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 8, 2021
@spiffxp spiffxp deleted the shard-some-groups branch September 8, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/groups Google Groups management, code in groups/ area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants