Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: update as of 2021-09-20 #2748

Merged
merged 1 commit into from Sep 20, 2021

Conversation

k8s-infra-ci-robot
Copy link
Contributor

Audit Updates wg-k8s-infra

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2021
@k8s-infra-ci-robot k8s-infra-ci-robot force-pushed the autoaudit-prow branch 2 times, most recently from 3b25f25 to 48171ba Compare September 17, 2021 14:55
@k8s-infra-ci-robot k8s-infra-ci-robot changed the title audit: update as of 2021-09-17 audit: update as of 2021-09-18 Sep 18, 2021
@k8s-infra-ci-robot k8s-infra-ci-robot force-pushed the autoaudit-prow branch 2 times, most recently from ca8965f to 61e29a4 Compare September 18, 2021 16:57
@k8s-infra-ci-robot k8s-infra-ci-robot changed the title audit: update as of 2021-09-18 audit: update as of 2021-09-20 Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2021
@@ -15,7 +15,8 @@
{
"members": [
"group:k8s-infra-gcp-accounting@kubernetes.io",
"group:k8s-infra-prod-readiness@kubernetes.io"
"group:k8s-infra-prod-readiness@kubernetes.io",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by #2744

@@ -15,7 +15,8 @@
{
"members": [
"group:k8s-infra-gcp-accounting@kubernetes.io",
"group:k8s-infra-prod-readiness@kubernetes.io"
"group:k8s-infra-prod-readiness@kubernetes.io",
"serviceAccount:bq-data-transfer-kettle@kubernetes-public.iam.gserviceaccount.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by #2747

Comment on lines +30 to +35
{
"members": [
"serviceAccount:service-127754664067@gcp-sa-bigquerydatatransfer.iam.gserviceaccount.com"
],
"role": "roles/bigquerydatatransfer.serviceAgent"
},
Copy link
Member

@ameukam ameukam Sep 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a manual run of the transfer job. #2749

@@ -0,0 +1,8 @@
{
"description": "Service Acccount BigQuery Data Transfer",
"email": "bq-data-transfer-kettle@kubernetes-public.iam.gserviceaccount.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by #2737

@@ -0,0 +1,8 @@
{
"displayName": "default service account for pods in aaa",
"email": "kettle@kubernetes-public.iam.gserviceaccount.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by #2737

Comment on lines +4 to +7
"members": [
"serviceAccount:kubernetes-public.svc.id.goog[kettle/kettle]"
],
"role": "roles/iam.workloadIdentityUser"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added by #2737

Comment on lines +3 to +8
"role": "WRITER",
"userByEmail": "bq-data-transfer-kettle@kubernetes-public.iam.gserviceaccount.com"
},
{
"role": "WRITER",
"userByEmail": "kettle@kubernetes-public.iam.gserviceaccount.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done by #2737

@@ -1,5 +1,6 @@
NAME TITLE
bigquery.googleapis.com BigQuery API
bigquerydatatransfer.googleapis.com BigQuery Data Transfer API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled by #2749

@ameukam
Copy link
Member

ameukam commented Sep 20, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, k8s-infra-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4589de8 into kubernetes:main Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/audit Audit of project resources, audit followup issues, code in audit/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants