Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcp-compute-persistent-disk-csi-driver v1.8.0 #4294

Merged
merged 1 commit into from Oct 21, 2022
Merged

gcp-compute-persistent-disk-csi-driver v1.8.0 #4294

merged 1 commit into from Oct 21, 2022

Conversation

mattcary
Copy link
Contributor

/assign @leiyiz

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added area/k8s.gcr.io Code in k8s.gcr.io/ approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2022
@mattcary mattcary mentioned this pull request Sep 30, 2022
Closed
@jenting
Copy link

jenting commented Oct 21, 2022

ping @leiyiz

Any update?

leiyiz
leiyiz reviewed Oct 21, 2022
View reviewed changes
Copy link
Contributor

@leiyiz leiyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leiyiz, mattcary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@leiyiz
Copy link
Contributor

leiyiz commented Oct 21, 2022

ping @leiyiz

Any update?

thanks for the ping, just back from a leave.

@k8s-ci-robot k8s-ci-robot merged commit 09433f9 into kubernetes:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leiyiz leiyiz leiyiz left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

@saikat-royc saikat-royc Awaiting requested review from saikat-royc

Assignees

@leiyiz leiyiz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattcary @jenting @k8s-ci-robot @leiyiz