Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image promotion for etcd 3.5.8-0 #5157

Merged
merged 1 commit into from
May 10, 2023

Conversation

kkkkun
Copy link
Member

@kkkkun kkkkun commented Apr 24, 2023

Part of kubernetes/kubernetes#117341

Based on: kubernetes/kubernetes#117332

 docker inspect  gcr.io/k8s-staging-etcd/etcd:3.5.8-0
[
    {
        "Id": "sha256:291c432e82cb31038db567f89db79530419118472a134b55f540291ceb4cd882",
        "RepoTags": [
            "gcr.io/k8s-staging-etcd/etcd:3.5.8-0"
        ],
        "RepoDigests": [
            "gcr.io/k8s-staging-etcd/etcd@sha256:b3a0da984f9af598234c018faa4f28dd6a6461f5719163a61f10ebf26dbca1e9"
        ],

Required for: kubernetes/kubernetes#117335

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 24, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @kkkkun!

It looks like this is your first PR to kubernetes/k8s.io 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/k8s.io has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @kkkkun. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Apr 24, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 24, 2023
@kkkkun
Copy link
Member Author

kkkkun commented Apr 24, 2023

After kubernetes/kubernetes#117332 merged. I found https://console.cloud.google.com/gcr/images/k8s-staging-etcd/global/etcd only has a image with 3.5.8-0-linux-amd64 ? How to make a image like tag 3.5.8-0 or other?

Could someone help me?

@pacoxu
Copy link
Member

pacoxu commented Apr 24, 2023

@kkkkun
Copy link
Member Author

kkkkun commented Apr 24, 2023

I think you should change https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-etcd/images.yaml#L17 instead.

Thanks. I would update https://github.com/kubernetes/k8s.io/blob/main/registry.k8s.io/images/k8s-staging-etcd/images.yaml#L17.

But i do not found etcd:v3.5.8-0. Is etcd:v3.5.8-0 uploaded to cloud after kubernetes/kubernetes#117332 merged?

scuzk373x@cloudshell:~$ docker pull gcr.io/k8s-staging-etcd/etcd:3.5.7-1
3.5.7-1: Pulling from k8s-staging-etcd/etcd
fc251a6e7981: Pull complete
d3f87714a769: Pull complete
023296d9c7d3: Pull complete
bde6aaca8edf: Pull complete
Digest: sha256:ffc66c1e20edb459665425b08f21f0d3c051099a0020437e9e9d444184c08649
Status: Downloaded newer image for gcr.io/k8s-staging-etcd/etcd:3.5.7-1
gcr.io/k8s-staging-etcd/etcd:3.5.7-1
scuzk373x@cloudshell:~$
scuzk373x@cloudshell:~$ docker pull gcr.io/k8s-staging-etcd/etcd:3.5.8-0
Error response from daemon: manifest for gcr.io/k8s-staging-etcd/etcd:3.5.8-0 not found: manifest unknown: Failed to fetch "3.5.8-0" from request "/v2/k8s-staging-etcd/etcd/manifests/3.5.8-0".
scuzk373x@cloudshell:~$
scuzk373x@cloudshell:~$ docker pull registry.k8s.io/k8s-staging-etcd/etcd:3.5.8-0
Error response from daemon: manifest for registry.k8s.io/k8s-staging-etcd/etcd:3.5.8-0 not found: manifest unknown: Failed to fetch "3.5.8-0"

@xmudrii
Copy link
Member

xmudrii commented Apr 24, 2023

@kkkkun That is correct, however, the postsubmit failed: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-image-etcd/1649533793343639552

I think it might be related to removing support for arm (cc @saschagrunert @dims).

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Apr 24, 2023
@kkkkun
Copy link
Member Author

kkkkun commented Apr 24, 2023

@kkkkun That is correct, however, the postsubmit failed: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-kubernetes-push-image-etcd/1649533793343639552

I think it might be related to removing support for arm (cc @saschagrunert @dims).

Add kubernetes/kubernetes#117557 to track.

@kkkkun
Copy link
Member Author

kkkkun commented May 10, 2023

We need merge this change firstly before kubernetes/kubernetes#117335 (comment).

@pacoxu @xmudrii

Signed-off-by: kkkkun <scuzk373x@gmail.com>
Copy link
Member

@pacoxu pacoxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@pacoxu
Copy link
Member

pacoxu commented May 10, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 10, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2023
@pacoxu
Copy link
Member

pacoxu commented May 10, 2023

/assign @xmudrii @justaugustus

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkkkun, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8e1f628 into kubernetes:main May 10, 2023
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 10, 2023
@kkkkun kkkkun deleted the etcd-3.5.8-image branch May 10, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants