eks-prow-build-cluster: GitOps proposal #5336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
|
Overall looks fairly clean. It's Similar to other approaches to using flux. |
sbdtu5498
reviewed
May 30, 2023
xmudrii
suggested changes
Jun 1, 2023
infra/aws/terraform/prow-build-cluster/resources/flux-system/ks-boskos.yaml
Outdated
Show resolved
Hide resolved
.../aws/terraform/prow-build-cluster/resources/node-problem-detector/node-problem-detector.yaml
Outdated
Show resolved
Hide resolved
Create kustomization for external-secrets
pkprzekwas
force-pushed
the
eks-prow-build-cluster-gitops
branch
from
1ea28cb
to
406c547
Compare
xmudrii
suggested changes
Jun 1, 2023
xmudrii
suggested changes
Jun 1, 2023
Co-authored-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Co-authored-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii
reviewed
Jun 2, 2023
xmudrii
approved these changes
Jun 2, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pkprzekwas, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Description
This PR presents working GitOps proposal for EKS prow build cluster. It's based on FluxCD. The motivation for choosing FluxCD: "it's simple and doesn't require configuring any GH tokens or webhooks". This is more or less what we are looking for as we don't expect any complex deployment workflows. We aim to enable maintainers to easily introduce changes to k8s resources running on EKS prow build cluster.
Presented solution has been running for the past couple of days on prow-canary-cluster.
Potential improvements
Other stuff
Introducing image updater has been skipped as it requires write permissions to GH repository.
/ref #5170
/assign @xmudrii @hh