Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Add Service endpoints to VPC #6139

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

ameukam
Copy link
Member

@ameukam ameukam commented Dec 4, 2023

Add service endpoints for AWS Services used in kops-ci account.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. labels Dec 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 4, 2023
@ameukam
Copy link
Member Author

ameukam commented Dec 4, 2023

/hold
cc @dims @bryantbiggs

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 4, 2023
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k8s-ci-robot
Copy link
Contributor

@bryantbiggs: changing LGTM is restricted to collaborators

In response to this:

LGTM!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims
Copy link
Member

dims commented Dec 4, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, bryantbiggs, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
Add service endpoints for AWS Services used in kops-ci account.

Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
@ameukam
Copy link
Member Author

ameukam commented Dec 4, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2023
@dims
Copy link
Member

dims commented Dec 4, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0672ee9 into kubernetes:main Dec 4, 2023
3 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 4, 2023
@ameukam
Copy link
Member Author

ameukam commented Dec 4, 2023

VPC Endpoints created:

aws ec2 describe-vpc-endpoints --region us-east-2 --query 'VpcEndpoints[*].ServiceName' --output table
--------------------------------------------------
|              DescribeVpcEndpoints              |
+------------------------------------------------+
|  com.amazonaws.us-east-2.s3                    |
|  com.amazonaws.us-east-2.ecr.dkr               |
|  com.amazonaws.us-east-2.ec2                   |
|  com.amazonaws.us-east-2.sqs                   |
|  com.amazonaws.us-east-2.sts                   |
|  com.amazonaws.us-east-2.ssm                   |
|  com.amazonaws.us-east-2.eks-auth              |
|  com.amazonaws.us-east-2.kms                   |
|  com.amazonaws.us-east-2.elasticloadbalancing  |
|  com.amazonaws.us-east-2.ec2messages           |
|  com.amazonaws.us-east-2.events                |
|  com.amazonaws.us-east-2.ecr.api               |
|  com.amazonaws.us-east-2.ssmmessages           |
|  com.amazonaws.us-east-2.autoscaling           |
|  com.amazonaws.us-east-2.logs                  |
+------------------------------------------------+

@ameukam
Copy link
Member Author

ameukam commented Dec 8, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/infra/aws Issues or PRs related to Kubernetes AWS infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants