Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster-api-provider-digitalocean to image promoter #671

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Add cluster-api-provider-digitalocean to image promoter #671

merged 2 commits into from
Mar 20, 2020

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Mar 19, 2020

Add a staging GCR bucket for cluster-api-provider-digitalocean.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 19, 2020
xmudrii
xmudrii commented Mar 19, 2020
View reviewed changes
Copy link
Member Author

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two questions about the process.

k8s.gcr.io/images/k8s-staging-cluster-api-do/images.yaml Outdated
@@ -0,0 +1,3 @@
- name: cluster-api-do-controller
dmap:
"sha256:": ["v0.3.0"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the process to get the SHA256? Should I first cut the release, build the image locally, and then past the SHA256? Is there some other process?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't actually need to list any images prior to having an image pushed to staging first.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you have a published staging image, you can get the sha either from the output of the job that is pushing the image, or you can look in the GCR registry through the console, for example the staging repo for cluster-api-provider-aws is viewable here: https://console.cloud.google.com/gcr/images/k8s-staging-cluster-api-aws/GLOBAL/cluster-api-aws-controller?project=k8s-staging-cluster-api-aws&gcrImageListsize=30 (may not be viewable if you are not in the group membership)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense! Thanks for the explanation! I've dropped this file from the PR.

groups/groups.yaml
settings:
ReconcileMembers: "true"
members:
- mudrinic.mare@gmail.com
Copy link
Member Author

@xmudrii xmudrii Mar 19, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now, I'm the only one maintainer of the CAPI-DO project (SCL mailing list post for more details). We will add two more maintainers after the lazy consensus passes on 3/25.

Is it okay that I'm the only member/owner for now? Should I wait for new maintainers to get promoted or add someone from SCL/Cluster-API?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single owner/member here should be fine for now, I'm also more than happy to be a backup resource to assist if needed as well.

@xmudrii xmudrii changed the title [WIP] Add staging GCR bucket for cluster-api-do Add staging GCR bucket for cluster-api-do Mar 19, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 19, 2020
@detiber
Copy link
Member

detiber commented Mar 19, 2020

@xmudrii I think you'll need the image yaml file, just with an empty dmap dict

@xmudrii
Copy link
Member Author

xmudrii commented Mar 19, 2020

@detiber I've updated the PR to look like #628

/cc @dims @cblecker @thockin
we will need the google group and bucket created

@xmudrii xmudrii changed the title Add staging GCR bucket for cluster-api-do Add cluster-api-provider-digitalocean to image promoter Mar 19, 2020
@ncdc ncdc mentioned this pull request Mar 19, 2020
Merged
@MorrisLaw MorrisLaw mentioned this pull request Mar 20, 2020
Closed
6 tasks
@dims
Copy link
Member

dims commented Mar 20, 2020

@xmudrii please add @detiber as well.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@xmudrii
Copy link
Member Author

xmudrii commented Mar 20, 2020

@dims Done, PTAL.

@dims
Copy link
Member

dims commented Mar 20, 2020

/hold cancel
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2020
@detiber
Copy link
Member

detiber commented Mar 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 729fa29 into kubernetes:master Mar 20, 2020
thockin
thockin reviewed Mar 20, 2020
View reviewed changes
infra/gcp/ensure-staging-storage.sh
@@ -46,6 +46,7 @@ STAGING_PROJECTS=(
cluster-api
cluster-api-aws
cluster-api-azure
cluster-api-do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@detiber Why are some "cluster-api" and others "capi" ? Is there a principle as to which to use?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's related to the max length of the names, but I'm not sure if it's related to GCR names or GCS Bucket ones?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's related to the max length of the names, but I'm not sure if it's related to GCR names or GCS Bucket ones?

Yes, I believe the same. cluster-api-do is less than 18 characters, so I went with that name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartsmykla is correct, the main reason for the bifurcation was due to character length. We'll work to unify the naming as we work on the proposal for nesting.

thockin
thockin reviewed Mar 20, 2020
View reviewed changes
k8s.gcr.io/manifests/k8s-staging-cluster-api-do/promoter-manifest.yaml
registries:
- name: gcr.io/k8s-staging-cluster-api-do
src: true
- name: us.gcr.io/k8s-artifacts-prod/cluster-api-do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@detiber Have you given thought to "nesting" of cluster-api in GCR-space?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thockin It seems like there is some discussion ongoing here #658 (comment). However, I believe that is out of the scope of this PR and out of the scope for CAPI-DO maintainers.

thockin
thockin reviewed Mar 20, 2020
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we actuate this - I have questions on name.

@xmudrii
Copy link
Member Author

xmudrii commented Mar 23, 2020

Before we actuate this - I have questions on name.

@thockin @dims told me that that the bucket is ready. Is there anything else that should be done before we can use it?

@xmudrii xmudrii deleted the capi-do branch March 23, 2020 11:17
@detiber
Copy link
Member

detiber commented Mar 23, 2020

@xmudrii once the bucket has been created it should be all ready for use now.

Will reach out over slack to point you towards the automation of how we are building images and pushing to staging for other providers today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@thockin thockin thockin left review comments

@bartsmykla bartsmykla bartsmykla left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

@cblecker cblecker Awaiting requested review from cblecker

@dims dims Awaiting requested review from dims

Assignees

@dims dims

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xmudrii @detiber @dims @k8s-ci-robot @thockin @bartsmykla