Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

groups: add more convention tests, fixup groups.yaml #925

Merged
merged 2 commits into from May 29, 2020
Merged

groups: add more convention tests, fixup groups.yaml #925

merged 2 commits into from May 29, 2020

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented May 29, 2020

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin May 29, 2020 20:41
@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. wg/k8s-infra approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 29, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2020
@spiffxp spiffxp changed the title groups: read group path as relative to config path groups: add more convention tests, fixup groups.yaml May 29, 2020
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 47a6242 into kubernetes:master May 29, 2020
@spiffxp spiffxp deleted the groups-path-relative-to-groups-config branch May 29, 2020 21:53
This was referenced May 29, 2020
Closed
Closed
Closed
@spiffxp
Copy link
Member Author

spiffxp commented May 29, 2020

ref #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spiffxp @cblecker @k8s-ci-robot