Skip to content

Commit

Permalink
Don't set extra structured log arguments
Browse files Browse the repository at this point in the history
Signed-off-by: James Munnelly <james@munnelly.eu>
  • Loading branch information
munnerz committed Jul 19, 2019
1 parent c96b964 commit eae9d56
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions klog.go
Original file line number Diff line number Diff line change
Expand Up @@ -817,11 +817,12 @@ func (l *loggingT) output(s severity, log logr.InfoLogger, buf *buffer, file str
}
data := buf.Bytes()
if log != nil {
keysAndValues := []interface{}{"severity", severityName[s], "file", file, "line", line}
// TODO: set 'severity' and caller information as structured log info
// keysAndValues := []interface{}{"severity", severityName[s], "file", file, "line", line}
if s == errorLog {
l.logr.Error(nil, string(data), keysAndValues...)
l.logr.Error(nil, string(data))
} else {
log.Info(string(data), keysAndValues...)
log.Info(string(data))
}
} else if l.toStderr {
os.Stderr.Write(data)
Expand Down

0 comments on commit eae9d56

Please sign in to comment.