Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #20 from munnerz/logr" #97

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 19, 2019

This reverts commit cd60aa4, reversing
changes made to a6a74fb.

What this PR does / why we need it:
Reverts API-breaking changes in advance of klog/v2

After merging this, the plan is to tag v1.0.0 and switch the module declaration to k8.io/klog/v2 before making breaking changes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref kubernetes/client-go#677 Azure/phippyandfriends#30 DataDog/dd-trace-go#482 kubernetes/client-go#658 kubernetes/client-go#656 kubernetes/client-go#654 kubernetes/client-go#652

See discussion in #20 (comment)

/cc @dims @munnerz @deads2k @DirectXMan12

This reverts commit cd60aa4, reversing
changes made to a6a74fb.
@k8s-ci-robot
Copy link

Welcome @liggitt!

It looks like this is your first PR to kubernetes/klog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/klog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2019
@dims
Copy link
Member

dims commented Sep 19, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2019
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2ca9ad3 into kubernetes:master Sep 19, 2019
@liggitt liggitt deleted the revert-logr branch September 19, 2019 12:44
@lavalamp
Copy link
Member

lavalamp commented Nov 7, 2019

Thanks; I strongly agree that klog should do versions properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants