Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Convert Docker Compose file" to just "Convert Compose file" #1868

Closed
cdrage opened this issue Apr 25, 2024 · 0 comments · Fixed by #1869
Closed

Remove "Convert Docker Compose file" to just "Convert Compose file" #1868

cdrage opened this issue Apr 25, 2024 · 0 comments · Fixed by #1869
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@cdrage
Copy link
Member

cdrage commented Apr 25, 2024

Expected Behavior

It says:

▶ ./kompose convert --help
Convert a Docker Compose file

It should just be

Convert a Compose file

Actual Behavior

Shows Docker name, should just say Compose

Steps To Reproduce

No response

Kompose Version

latest

Docker-Compose file

No response

Anything else?

No response
@cdrage cdrage added the kind/bug Categorizes issue or PR as related to a bug. label Apr 25, 2024
cdrage added a commit to cdrage/kompose that referenced this issue Apr 25, 2024
@cdrage
update references to just compose
bfd6ed6 
#### What type of PR is this?

Change from Docker Compose references to just Compose

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind documentation
/kind feature
-->

#### What this PR does / why we need it:

Compose is an open format and we should not say "Docker Compose".

#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

Fixes kubernetes#1868

#### Special notes for your reviewer:

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage mentioned this issue Apr 25, 2024
Merged
TessaIO pushed a commit that referenced this issue Apr 26, 2024
@cdrage
update references to just compose (#1869)
50e0408 
#### What type of PR is this?

Change from Docker Compose references to just Compose

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind documentation
/kind feature
-->

#### What this PR does / why we need it:

Compose is an open format and we should not say "Docker Compose".

#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

Fixes #1868

#### Special notes for your reviewer:

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update references to just compose cdrage/kompose
1 participant
@cdrage