Allow specifying imagePullSecret

[jmatsushita]

Hi there,

How would one go about providing the imagePullSecret key to a deployment?

This could possibly help with #893 ? This might also be part of a broader discussion about "template-supported conversions", which would allow to make custom changes to the conversion outputs...

Cheers,

Jun

[jmatsushita]

In fact, instead or in addition to "template-supported conversions", if the helm chart conversion template had a number of values interpolated, then the parameters could be passed to helm on deploy.

[Code0x58]

The issue with the case you linked is that the code tries doing something like docker push my-namespace/image:tag instead of docker push my-registry.com:5000/my-namespace/image:tag, to do with pushing from the client, rather than pulling from pods.

I think pod ImagePullSecrets fall into the same boat as ingress TLS secrets, so whoever takes this on could use #896 as a point of reference for the code.

[berryp]

Does this mean we cannot pull from external private registries right now?

[Code0x58]

You can't pull from an private registry if you would need to authenticate from the node to pull an image.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[ysle]

Hi,
okay, so this is to stay i simply can't use the lovely Kompose service as it if the given docker image is private right ?

[hangyan]

@ysle In kubernetes, you can create a secret for you private registry and add it to the default serviceaccount ( in the same namespace). After this ,kubernetes will pull the image for you.

Check the doc: https://kubernetes.io/docs/concepts/configuration/secret/#arranging-for-imagepullsecrets-to-be-automatically-attached

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[jankal]

/reopen
This is important for deploying docker-compose files to a kubernetes cluster.

[k8s-ci-robot]

@jankal: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen
This is important for deploying docker-compose files to a kubernetes cluster.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jankal]

@Code0x58 anything new on this?

[Code0x58]

I haven't kept up with the development of Kompose for months, but as I left it hangyan's comment was the best existing solution, but a Kompose fix would have been easy by doing something like #896 to add another label to provide ImagePullSecrets similar to #896. #1040 is an active PR on it, so probably worth reviewing for anyone who is interested and has time.

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.