Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kompose.image-pull-secret and kompose.image-pull-policy #1091

Merged
merged 6 commits into from
Feb 7, 2019

Conversation

kiela
Copy link
Contributor

@kiela kiela commented Jan 2, 2019

This PR is a rebase of #1040 on top of the latest master.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2019
@kiela kiela changed the title Add kompose.image pull policy Add kompose.image-pull-secret and kompose.image-pull-policy Jan 2, 2019
@kiela
Copy link
Contributor Author

kiela commented Jan 3, 2019

/assign @sebgoa

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 3, 2019
@kiela
Copy link
Contributor Author

kiela commented Jan 4, 2019

/cc @cdrage

@cdrage
Copy link
Member

cdrage commented Jan 17, 2019

Sorry about the delay! I've reviewed the code and it looks good. Thank you for adding all the tests as well.

I'm just waiting for the SemaphoreCI integration tests to pass and then we'll be able to merge. At the moment I have to manually run the tests due to issues with SemaphoreCI not being granted access to the Kubernetes org.

Many thanks

@cdrage
Copy link
Member

cdrage commented Jan 30, 2019

Hey @kiela are you able to rebase?

@kiela kiela force-pushed the add-kompose.image-pull-policy branch from 8f67491 to b1ae469 Compare January 31, 2019 08:50
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: sebgoa

If they are not already assigned, you can assign the PR to them by writing /assign @sebgoa in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kiela
Copy link
Contributor Author

kiela commented Jan 31, 2019

Sure thing @cdrage!

@kiela
Copy link
Contributor Author

kiela commented Feb 7, 2019

Hi @cdrage, any chance to get this merged in?

@cdrage
Copy link
Member

cdrage commented Feb 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@cdrage
Copy link
Member

cdrage commented Feb 7, 2019

@kiela No changes to the code! This looks great. Thanks for your contribution.

I should have a release pushed for next week 💯

@cdrage cdrage merged commit 66ac4af into kubernetes:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants