-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement storing to directory or file, add functional tests #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Dec 14, 2016
wow Travis has still not started build, its more than hour now! |
concaf
force-pushed
the
output_file_dir
branch
2 times, most recently
from
December 15, 2016 15:10
4809abc
to
f1e3a7f
Compare
It looks like the commit message is empty? I only see a title in there. |
concaf
force-pushed
the
output_file_dir
branch
from
December 15, 2016 20:33
f1e3a7f
to
dac70d8
Compare
@cdrage, whoops, fixed! |
LGTM! |
surajssd
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 19, 2016
surajssd
approved these changes
Dec 19, 2016
Code LGTM, however @containscafeine mind explaining a little bit on the usage (how to use?). Seeing if we need to update the docs for this change :) |
cdrage
approved these changes
Dec 19, 2016
surajssd
added
rebase needed
and removed
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
labels
Dec 19, 2016
concaf
force-pushed
the
output_file_dir
branch
from
December 20, 2016 15:10
dac70d8
to
a782a5e
Compare
When kompose convert -o artifacts is run, then if artifacts is a directory, kompose stores all the resulting files inside it, and if it's not a directory, it stores the artifacts in a single file. Fixes kubernetes#209
concaf
force-pushed
the
output_file_dir
branch
from
December 21, 2016 12:43
a782a5e
to
365fe81
Compare
@containscafeine thanks merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #209