Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Jenkinsfile for PR pipeline on Fabric8CD infrastructure #669

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Adding Jenkinsfile for PR pipeline on Fabric8CD infrastructure #669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
@Library('github.com/fabric8io/fabric8-pipeline-library@master')
def dummy
goTemplate{
dockerNode{
goMake{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add a check to see if the pipeline is part of a CI or CD. I.e. we dont want to run the release if we are running CI builds on Pull Requests. You could do something like this https://github.com/fabric8io/fabric8-init-tenant/blob/master/Jenkinsfile#L9-L24

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what this would do is run your CI pipelines for pull requests, it will create a snapshot image and add a comment to the PR once it's available for testing. Like this fabric8-services/fabric8-tenant#125 (comment)

Copy link
Contributor Author

@rupalibehera rupalibehera Jun 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So they just want CI and they are not looking for CD, this pipeline should run on PR and also while the PR is merged to master. Hence I did not explicitly check if it is CI or CD.
@pradeepto and @cdrage could you please confirm this ?

I am not sure if we still add this at least for the snapshot.
@rawlingsj

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rupalibehera Yeah, we just want CI.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good LGTM

githubOrganisation = 'kubernetes-incubator'
dockerOrganisation = 'fabric8'
project = 'kompose'
makeCommand = "PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/local/go/bin:/usr/local/glide:/usr/local/:/go/bin:/home/jenkins/go/bin \
&& bash script/test/cmd/fix_detached_head.sh && make test"
}
}
}