Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Jenkinsfile for PR pipeline on Fabric8CD infrastructure #669

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

rupalibehera
Copy link
Contributor

Initial commit adding Jenkinsfile for pr pipeline on fabric8CD(http://jenkins.cd.k8s.fabric8.io/job/kubernetes-incubator/)

This PR includes a Jenkinsfile which just does make test for now which will run the tests on every PR and on merge with master.
It uses golang version 1.8.1

The below things are not covered which are there in .travis.yml:

  1. It does not test with the Matrix of various versions of go lang.
  2. It does not do the coverage
  3. It does not sync the docs

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 23, 2017
@rupalibehera
Copy link
Contributor Author

I have signed the CLA

@kadel
Copy link
Member

kadel commented Jun 23, 2017

@rupalibehera you commit is created with your redhat email. It looks like you don't have that email associated with you github account. You might have to add redhat email to your github account or use the same email that you are using on github for that commit.

@rupalibehera
Copy link
Contributor Author

Thanks @kadel I just added my redhat email-id to github account, hopefully it works.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 23, 2017
@cdrage
Copy link
Member

cdrage commented Jun 26, 2017

CLA has been passed.

@rupalibehera Any way we could test this / authorize this / see what happens? Have you tested this against your Kompose fork?

Let us know!

This saves us having to merge this in, then merge something else, unmerge, etc just to get it test to see if it works.

Code LGTM!

Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rupalibehera
Copy link
Contributor Author

@cdrage , I have tested this against my kompose fork.
Here is the sample successful run : http://pastebin.test.redhat.com/497821
I can tag the experts to review this.
@rawlingsj it would be really great if you can review this PR once :)

def dummy
goTemplate{
dockerNode{
goMake{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add a check to see if the pipeline is part of a CI or CD. I.e. we dont want to run the release if we are running CI builds on Pull Requests. You could do something like this https://github.com/fabric8io/fabric8-init-tenant/blob/master/Jenkinsfile#L9-L24

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also what this would do is run your CI pipelines for pull requests, it will create a snapshot image and add a comment to the PR once it's available for testing. Like this fabric8-services/fabric8-tenant#125 (comment)

Copy link
Contributor Author

@rupalibehera rupalibehera Jun 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So they just want CI and they are not looking for CD, this pipeline should run on PR and also while the PR is merged to master. Hence I did not explicitly check if it is CI or CD.
@pradeepto and @cdrage could you please confirm this ?

I am not sure if we still add this at least for the snapshot.
@rawlingsj

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rupalibehera Yeah, we just want CI.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sounds good LGTM

@cdrage cdrage merged commit eb808c3 into kubernetes:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants