Merge pull request #8182 from rifelpet/fix-verify-staticcheck

Fix verify-staticcheck prow job
kubernetes · Dec 23, 2019 · 4fedf81 · 4fedf81
2 parents ebd7a29 + e7e9e62
commit 4fedf81
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -553,7 +553,7 @@ verify-bazel:
 	hack/verify-bazel.sh
 
 .PHONY: verify-staticcheck
-verify-staticcheck:
+verify-staticcheck: ${BINDATA_TARGETS}
 	hack/verify-staticcheck.sh
 
 # ci target is for developers, it aims to cover all the CI jobs

diff --git a/hack/.staticcheck_failures b/hack/.staticcheck_failures
@@ -1,12 +1,10 @@
 cloudmock/aws/mockelbv2
 cmd/kops
-dnsprovider/pkg/dnsprovider
 dnsprovider/pkg/dnsprovider/providers/aws/route53
 dnsprovider/pkg/dnsprovider/providers/coredns
 dnsprovider/pkg/dnsprovider/providers/google/clouddns
 dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal
 dnsprovider/pkg/dnsprovider/providers/google/clouddns/internal/stubs
-dnsprovider/pkg/dnsprovider/providers/openstack/designate
 node-authorizer/pkg/authorizers/aws
 node-authorizer/pkg/server
 pkg/instancegroups

diff --git a/hack/verify-staticcheck.sh b/hack/verify-staticcheck.sh
@@ -66,6 +66,8 @@ go install k8s.io/kops/vendor/honnef.co/go/tools/cmd/staticcheck
 
 cd "${KUBE_ROOT}"
 
+make upup/models/bindata.go
+
 # Check that the file is in alphabetical order
 failure_file="${KUBE_ROOT}/hack/.staticcheck_failures"
 if ! diff -u "${failure_file}" <(LC_ALL=C sort "${failure_file}"); then