Fix verify-staticcheck prow job #8182
Conversation
The new job was missing the generated files from go-bindata. I noticed some of the prow jobs use make and others call hack/ scripts directly. I think it'd be better to use make so we can more easily add dependencies like this, therefor I'd like to propose that we merge this, update the jobs to call make targets, then remove the make command I added to hack/verify-staticcheck.sh By fixing the existing job as well as the make target, we can unblock other PRs and not get another swarm of failure notifications when the job gets updated to use make.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@rifelpet: GitHub didn't allow me to request PR reviews from the following users: hakman. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks @rifelpet |
|
Well that explains all the emails I got :) /lgtm |
k8s-ci-robot
added
the
lgtm
The new job was missing the generated files from go-bindata. I tested this locally on a clean checkout.
I noticed some of the prow jobs use make and others call hack/ scripts directly.
I think it'd be better to use make so we can more easily add dependencies like this, therefor I'd like to propose that we merge this, update the job to call
make verify-staticcheckthen remove the make command from hack/verify-staticcheck.shBy fixing the existing job as well as the make target, we can unblock other PRs and not get another swarm of failure notifications when the job gets updated to use make.