Merge pull request #3488 from julianvmodesto/logrotate-coreos

Automatic merge from submit-queue.

Enable logrotate for Kubernetes configs on CoreOS

Addresses #2710.

Also, remove logrotate crontab because logrotate ships with a systemd timer, `logrotate.timer`, to run logrotate daily.

nodeup/pkg/model/logrotate.go

@@ -35,18 +35,15 @@ type LogrotateBuilder struct {
 var _ fi.ModelBuilder = &LogrotateBuilder{}
 
 func (b *LogrotateBuilder) Build(c *fi.ModelBuilderContext) error {
-	if b.Distribution == distros.DistributionCoreOS {
-		glog.Infof("Detected CoreOS; won't install logrotate")
-		return nil
-	}
-
 	if b.Distribution == distros.DistributionContainerOS {
 		glog.Infof("Detected ContainerOS; won't install logrotate")
 		return nil
+	} else if b.Distribution == distros.DistributionCoreOS {
+		glog.Infof("Detected CoreOS; won't install logrotate")
+	} else {
+		c.AddTask(&nodetasks.Package{Name: "logrotate"})
 	}
 
-	c.AddTask(&nodetasks.Package{Name: "logrotate"})
-
 	k8sVersion, err := util.ParseKubernetesVersion(b.Cluster.Spec.KubernetesVersion)
 	if err != nil || k8sVersion == nil {
 		return fmt.Errorf("unable to parse KubernetesVersion %q", b.Cluster.Spec.KubernetesVersion)