CoreOS logrotate

[adrianchifor]

Was just wondering why logrotate configs are not installed on CoreOS? Source:

kops/nodeup/pkg/model/logrotate.go

Line 38 in fea4df5

glog.Infof("Detected CoreOS; won't install logrotate")

[ghost]

I read the Git blame and the code, all container-centric distros don't get logrotate installed. I would assume the intention is to keep deployments on these distros as light as possible in concordance with the distros' design ethos.

@justinsb, you implemented logrotate for kops, could you confirm my suspicion?

[adrianchifor]

@WillemMali Thanks for the response, altought I just checked one of our base CoreOS v1353 nodes and there is a logrotate systemd service installed. kops 1.5.3 had logrotate configs at /etc/logrotate.d but since kops 1.6.0 we had to add them ourselves.

[chrislovecnm]

@adrianchifor what should we be doing? Was it getting installed in the past? Was it in the base image in the past? You are the user and know more than I do about CoreOS thank I do :)

[adrianchifor]

@chrislovecnm As far as I can remember, CoreOS has always had logrotate as a systemd service. We had kops 1.5.3 on our k8s clusters recently and the /etc/logrotate.d folder contained the k8s-related logrotate configs. When we upgraded to kops 1.6.0 the logrotate configs were gone.

Instead of checking the OS distribution if we need to apply the logrotate configs, we should check if logrotate is installed (check systemd or check if the binary exists at /usr/sbin/logrotate, default location on CoreOS).

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

[adrianchifor]

/close