Skip to content

Commit

Permalink
Merge pull request #6410 from justinsb/normalize_etcdclusterprovider_…
Browse files Browse the repository at this point in the history
…names

Normalize etcd cluster provider names
  • Loading branch information
k8s-ci-robot committed Feb 16, 2019
2 parents 764dec7 + 83ea1c4 commit 9090e8c
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion pkg/commands/set_cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,12 @@ func SetClusterFields(fields []string, cluster *api.Cluster, instanceGroups []*a
c.Version = kv[1]
}
case "cluster.spec.etcdClusters[*].provider":
p, err := toEtcdProviderType(kv[1])
if err != nil {
return err
}
for _, etcd := range cluster.Spec.EtcdClusters {
etcd.Provider = api.EtcdProviderType(kv[1])
etcd.Provider = p
}
case "cluster.spec.etcdClusters[*].manager.image":
for _, etcd := range cluster.Spec.EtcdClusters {
Expand All @@ -125,3 +129,15 @@ func SetClusterFields(fields []string, cluster *api.Cluster, instanceGroups []*a
}
return nil
}

func toEtcdProviderType(in string) (api.EtcdProviderType, error) {
s := strings.ToLower(in)
switch s {
case "legacy":
return api.EtcdProviderTypeLegacy, nil
case "manager":
return api.EtcdProviderTypeManager, nil
default:
return api.EtcdProviderTypeManager, fmt.Errorf("unknown etcd provider type %q", in)
}
}

0 comments on commit 9090e8c

Please sign in to comment.