Normalize etcd cluster provider names #6410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
chrisz100
reviewed
Jan 28, 2019
pkg/commands/set_cluster.go
Outdated
| @@ -125,3 +129,15 @@ func SetClusterFields(fields []string, cluster *api.Cluster, instanceGroups []*a | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func toEtcdProviderType(in string) api.EtcdProviderType { | |||
There was a problem hiding this comment.
didn't you miss the second return type for error here? 😕
There was a problem hiding this comment.
I sure did - thanks for spotting! Too many branches!
Instead of just casting a string, we validate and normalize.
justinsb
force-pushed
the
normalize_etcdclusterprovider_names
branch
from
dd54dc4
to
83ea1c4
Compare
|
Looks good! Thanks @justinsb! /retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, mikesplain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-kops-e2e-kubernetes-aws |
justinsb
added a commit
that referenced
this pull request
Feb 28, 2019
Cherry pick of #6410 onto release-1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just casting a string, we validate and normalize.