Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addon NTH rebalance recommendation flags #12082

Closed
CheyiLin opened this issue Jul 31, 2021 · 0 comments · Fixed by #12083
Closed

Add addon NTH rebalance recommendation flags #12082

CheyiLin opened this issue Jul 31, 2021 · 0 comments · Fixed by #12083
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@CheyiLin
Copy link
Contributor

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see.

It would be great if we can have the following 2 rebalance recommendation flags that the builtin NTH v1.13.0 supports:

AWS Node Termination Handler - IMDS Mode Configuration (refs)

Parameter Description Default
enableRebalanceMonitoring If true, cordon nodes when the rebalance recommendation notice is received false
enableRebalanceDraining If true, drain nodes when the rebalance recommendation notice is received false

2. Feel free to provide a design supporting your feature request.

These 2 flags will be false by default and will work only when the queue-processor mode EnableSQSTerminationDraining is off, just like the existing flags EnableSpotInterruptionDraining and EnableScheduledEventDraining.

PR is on the way. 😃

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants