-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nth rebalance recommendation configs #12083
Conversation
Welcome @CheyiLin! |
Hi @CheyiLin. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@olemarkus: GitHub didn't allow me to request PR reviews from the following users: haugenj. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@olemarkus I've just fixed the test, just wondering if you can approve the pending workflow? Thanks! |
/test ? |
@CheyiLin: The following commands are available to trigger required jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rifelpet |
Have no idea why Netlify checks failed, is there anything I can do to fix this? |
It seems like a setup issue with netlify. I don't know exactly what is causing that unfortunately. |
I think the PR itself looks good. So once we can sort of the netlify stuff (this most likely affects all PRs now), we can merge this. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
2 similar comments
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
@CheyiLin can you force push to your branch? Perhaps amend a commit message. I'm hoping that a force push is sufficient to get the netlify jobs to pass. /hold until that happens to silence the retest bot |
/hold cancel |
Fixes #12082