Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nth rebalance recommendation configs #12083

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Conversation

CheyiLin
Copy link
Contributor

Fixes #12082

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 31, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @CheyiLin!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @CheyiLin. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 31, 2021
@olemarkus
Copy link
Member

/ok-to-test
/cc @haugenj

@k8s-ci-robot
Copy link
Contributor

@olemarkus: GitHub didn't allow me to request PR reviews from the following users: haugenj.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/ok-to-test
/cc @haugenj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2021
@CheyiLin
Copy link
Contributor Author

CheyiLin commented Aug 2, 2021

/retest

@CheyiLin
Copy link
Contributor Author

CheyiLin commented Aug 2, 2021

@olemarkus I've just fixed the test, just wondering if you can approve the pending workflow? Thanks!

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2021
@CheyiLin
Copy link
Contributor Author

CheyiLin commented Aug 2, 2021

/test ?

@k8s-ci-robot
Copy link
Contributor

@CheyiLin: The following commands are available to trigger required jobs:

  • /test pull-kops-e2e-k8s-ci
  • /test pull-kops-e2e-k8s-ci-ha
  • /test pull-kops-e2e-k8s-docker
  • /test pull-kops-e2e-kubernetes-aws
  • /test pull-kops-e2e-k8s-crio
  • /test pull-kops-e2e-k8s-gce
  • /test pull-kops-e2e-aws-cloud-controller-manager
  • /test pull-kops-e2e-aws-cloud-controller-manager-irsa
  • /test pull-kops-e2e-aws-irsa
  • /test pull-kops-e2e-ipv6-conformance
  • /test pull-kops-e2e-aws-ebs-csi-driver
  • /test pull-e2e-kops-aws-load-balancer-controller
  • /test pull-e2e-kops-addon-resource-tracking
  • /test pull-kops-e2e-cni-amazonvpc
  • /test pull-kops-e2e-cni-calico
  • /test pull-kops-e2e-cni-canal
  • /test pull-kops-e2e-cni-cilium
  • /test pull-kops-e2e-cni-cilium-etcd
  • /test pull-kops-e2e-cni-flannel
  • /test pull-kops-e2e-cni-kuberouter
  • /test pull-kops-e2e-cni-weave
  • /test pull-kops-bazel-build
  • /test pull-kops-bazel-test
  • /test pull-kops-e2e-kubernetes-do-kubetest2
  • /test pull-kops-verify-bazel
  • /test pull-kops-verify-generated
  • /test pull-kops-verify-gomod
  • /test pull-kops-verify-boilerplate
  • /test pull-kops-verify-gofmt
  • /test pull-kops-verify-govet
  • /test pull-kops-verify-staticcheck
  • /test pull-kops-verify-hashes
  • /test pull-kops-verify-terraform
  • /test pull-kops-verify-cloudformation

Use /test all to run the following jobs that were automatically triggered:

  • pull-kops-e2e-kubernetes-aws
  • pull-kops-bazel-build
  • pull-kops-bazel-test
  • pull-kops-verify-bazel
  • pull-kops-verify-generated
  • pull-kops-verify-gomod
  • pull-kops-verify-boilerplate
  • pull-kops-verify-gofmt
  • pull-kops-verify-govet
  • pull-kops-verify-staticcheck
  • pull-kops-verify-terraform
  • pull-kops-verify-cloudformation

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CheyiLin
Copy link
Contributor Author

CheyiLin commented Aug 2, 2021

/assign @rifelpet

@CheyiLin
Copy link
Contributor Author

CheyiLin commented Aug 2, 2021

Have no idea why Netlify checks failed, is there anything I can do to fix this?

@olemarkus
Copy link
Member

It seems like a setup issue with netlify. I don't know exactly what is causing that unfortunately.

@olemarkus
Copy link
Member

I think the PR itself looks good. So once we can sort of the netlify stuff (this most likely affects all PRs now), we can merge this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2021
@k8s-triage-robot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

2 similar comments
@k8s-triage-robot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-triage-robot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@rifelpet
Copy link
Member

rifelpet commented Aug 3, 2021

@CheyiLin can you force push to your branch? Perhaps amend a commit message. I'm hoping that a force push is sufficient to get the netlify jobs to pass.

/hold until that happens to silence the retest bot

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2021
@rifelpet
Copy link
Member

rifelpet commented Aug 3, 2021

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 3, 2021
@k8s-ci-robot k8s-ci-robot merged commit 283080b into kubernetes:master Aug 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Aug 3, 2021
@CheyiLin CheyiLin deleted the nth branch August 3, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add addon NTH rebalance recommendation flags
5 participants