Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for timezones / user data #1794

Closed
dlutsch opened this issue Feb 6, 2017 · 15 comments
Closed

Add support for timezones / user data #1794

dlutsch opened this issue Feb 6, 2017 · 15 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@dlutsch
Copy link

dlutsch commented Feb 6, 2017

We have a need to create our kops nodes in PST rather than UTC. It would be helpful if kops either had an option to set the instance timezone via the ig config, or if ec2 user data could be passed in order to set that.

@dlutsch dlutsch changed the title Add support for timezones Add support for timezones / user data Feb 6, 2017
@justinsb
Copy link
Member

justinsb commented Feb 9, 2017

Hmmm... that's an unusual request :-) Do you mind if I ask why?

(I'm wondering if the pods inherit the node timezone, and whether they should).

Also I presume this would be a cluster-wide setting, or do you really mean per-instancegroup?

I'm torn between a label/annotation on the cluster, vs allowing you to run a custom script at bootup. We could also just do a property, as I guess most people won't even see it unless they need it.

@chrislovecnm
Copy link
Contributor

I have worked in IT groups where they want to run their servers in a certain TZ. @dlutsch I would recommend modifying the base ami to set your TZ. Admittedly I never recommend running servers in non-UTC tz, but I understand you may have other requirements.

@ffjia
Copy link

ffjia commented Feb 10, 2017

It might make sense to let kops support EC2 user-data, since we could use it to do some customized settings (like install extra packages) using Cloud-init.

@mirague
Copy link

mirague commented Feb 20, 2017

I agree, having an ability to pass in EC2 user data would be extremely helpful.

@igoratencompass
Copy link

+1 on user-data

@justinsb
Copy link
Member

justinsb commented Apr 3, 2017

We're discussing different approaches to this:
#1766
#2260

"User-Data" can be a lot of things - if you have specific use cases that would be handy to help figure out what we need to support.

I have noted:

  • setting the timezone
  • install extra packages

The problem with "just use cloud-init" is that some distros support different versions of cloud-init (CoreOS) and some don't support cloud-init at all (Container-Optimized OS). Also kops itself uses cloud-init on OSes where it is supported, and it isn't necessarily trivial to just combine two operations.

@swestcott
Copy link

@justinsb We're using CoreOS/Container Linux. I've listed some of our use cases below. I realise we could achieve some of these by rolling our own AMI, but we're keen stick with CoreOS's AMI to take full advantage of Container Linux's "auto update" feature. Even with a custom AMI, we'd need to provide some environment config for prod vs non-prod clusters.

  • Configure SSSD/Kerberos
  • Load additional systemd services/units e.g. forward SSHD denys to our corporate SIEM platform, register nodes with our CMDB
  • Apply relevant recommendations from CIS docker benchmarks
  • A custom MOTD :)

@venth
Copy link

venth commented Sep 20, 2017

How can I adjust timezone for kops 1.7? Is there any workaround for now?

@chrislovecnm
Copy link
Contributor

@venth I typically run the image in UTC. If you really need to, you could use a hook to change the TZ, which is NOT tested :) Here is more information on hooks https://github.com/kubernetes/kops/blob/master/docs/cluster_spec.md#hooks

@venth
Copy link

venth commented Sep 21, 2017

Thanks 👍

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 9, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@mayrbenjamin92
Copy link

/reopen

We would also love to have support for this!

@k8s-ci-robot
Copy link
Contributor

@mayrbenjamin92: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

We would also love to have support for this!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests