-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing tags on existing AWS VPC subnets in kops 1.5.3 #2388
Comments
This is a possible duplicate of #1142 (or it's root cause, so fixing one fixes both) |
I am also seeing this issue and had to manually tag my subnets to ensure that ELBs were created within AWS. |
I just created a new cluster with Kops 1.6.1 without any tags on the existing subnets and my ELB registered to all subnets. The ELB has the tags: Edit 2017-07.19: |
I've just created a K8 cluster using kops 1.6.0 on my subnets which had no tags. No additional tags were applied to my subnets after have deploying the K8 cluster on it. |
@adrianmkng yes that's correct. My last comment was incorrect unfortunately. I edited it. They are both related to kubernetes/kubernetes#42957 and kubernetes/kubernetes#42963 |
Closed in #3682 |
When creating k8s cluster with kops-1.5.3 in existing AWS VPC the
Name
andKubernetesCluster
tags are not being applied to the subnets. Apparently their values should be something like:Additional to this, a care should be taken for the cases where one or both of these tags already exist for the subnet (especially the
Name
one which is pretty common). Maybe more unique tag keys should be considered to avoid any clash with existing ones. I don't think overwriting existing ones is the correct action to take as people might have some VPC operations depending on the existing subnet tag. I apologize if this is already dealt with in the code.The text was updated successfully, but these errors were encountered: