Missing tags on existing AWS VPC subnets in kops 1.5.3

[igoratencompass]

When creating k8s cluster with kops-1.5.3 in existing AWS VPC the Name and KubernetesCluster tags are not being applied to the subnets. Apparently their values should be something like:

    KubernetesCluster = "<cluster-name>"
    Name              = "eu-west-1a.<cluster-name>"

Additional to this, a care should be taken for the cases where one or both of these tags already exist for the subnet (especially the Name one which is pretty common). Maybe more unique tag keys should be considered to avoid any clash with existing ones. I don't think overwriting existing ones is the correct action to take as people might have some VPC operations depending on the existing subnet tag. I apologize if this is already dealt with in the code.

[kenden]

This is a possible duplicate of #1142 (or it's root cause, so fixing one fixes both)

[onlydole]

I am also seeing this issue and had to manually tag my subnets to ensure that ELBs were created within AWS.

[kenden]

I just created a new cluster with Kops 1.6.1 without any tags on the existing subnets and my ELB registered to all subnets. The ELB has the tags:
KubernetesCluster: k8s.prod.eu-central-1.redacted.net
kubernetes.io/cluster/k8s.prod.eu-central-1.redacted.net: owned
This new tag kubernetes.io/cluster/..., from here seems to have helped

Edit 2017-07.19:
It is not correct. Subnets must have a tag in order to be added to the ELB, with Kops/Kubernetes 1.6.2.
With the tag:
kubernetes.io/cluster/k8s.prod.eu-central-1.redacted.net: owned, the subnets are added.
See related Kops ticket comment: #1142 (comment)

[adrianmkng]

I've just created a K8 cluster using kops 1.6.0 on my subnets which had no tags. No additional tags were applied to my subnets after have deploying the K8 cluster on it.
Next I created a LoadBalancer service type on the K8 cluster I could see it failed to register all the subnets to my ELB.
As I understand it, the existing subnets should have the tags kubernetes.io/cluster/... : shared applied to it so that the ELB is aware that the subnets are being managed by kops. Is this understanding correct?

[kenden]

@adrianmkng yes that's correct. My last comment was incorrect unfortunately. I edited it.
I think we should close either this ticket or #1142.

They are both related to kubernetes/kubernetes#42957 and kubernetes/kubernetes#42963

[geojaz]

Closed in #3682