Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom secrets from S3 are not populated to known_tokens.csv with Kops 1.9 #5090

Closed
3h4x opened this issue May 2, 2018 · 14 comments
Closed
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@3h4x
Copy link

3h4x commented May 2, 2018

  1. What kops version are you running? The command kops version, will display
    this information.

Version 1.9.0 (git-cccd71e67)

  1. What Kubernetes version are you running? kubectl version will print the
    version if a cluster is running or provide the Kubernetes version specified as
    a kops flag.
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.6", GitCommit:"9f8ebd171479bec0ada837d7ee641dec2f8c6dd1", GitTreeState:"clean", BuildDate:"2018-03-21T15:21:50Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.10", GitCommit:"044cd262c40234014f01b40ed7b9d09adbafe9b1", GitTreeState:"clean", BuildDate:"2018-03-19T17:44:09Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}
  1. What cloud provider are you using?

AWS

  1. What commands did you run? What is the simplest way to reproduce this issue?

Change binary of kops from 1.8.1 to 1.9. Update cluster and rollout.

In our S3 bucket we have custom secrets that were populated to /srv/kubernetes/known_tokens.csv when cluster was updated with kops < 1.9
After rolling update /srv/kubernetes/known_tokens.csv was lacking our secrets and we have to rollout cluster with kops 1.8.1

  1. What happened after the commands executed?

Commands are okay but logic of populating kops secrets has changed.
We have found this PR merged which is causing us trouble
https://github.com/kubernetes/kops/pull/3835/files#diff-a7e5ed2b01f8673379c76c3d0b880c8cR270

  1. What did you expect to happen?

I expected that upgrading kops won't break kubernetes functionality and secrets will be populated like in 1.8.1 version

  1. Anything else do we need to know?

This should be in ugprade information because it's breaking change for people using secrets from S3.


If there is a way to populate secretes with 1.9 we can upgrade kops but before that it's blocking for me.

@3h4x 3h4x changed the title Secrets from S3 are not populated to known_tokens.csv with Kops 1.9 Custom secrets from S3 are not populated to known_tokens.csv with Kops 1.9 May 4, 2018
@pracucci
Copy link

pracucci commented May 4, 2018

@justinsb This is the issue with custom auth tokens we've encountered in kops 1.9, I was talking to you about during lunch at KubeCon.

@liskl
Copy link

liskl commented May 4, 2018

Hitting the same issue here, looking into a possible systemd unit solution to make it happen, will report back if i make progress.

@ilavender
Copy link

any news? did somebody find a workaround?

@nitrogear
Copy link

is it working in kops 1.10?

@followsound
Copy link

Any updates to this? We have hit the exact same issue

@3h4x
Copy link
Author

3h4x commented Aug 8, 2018

No updates just workarounds

@followsound
Copy link

The workaround being?

@3h4x
Copy link
Author

3h4x commented Aug 8, 2018

@followsound
Either use kops-1.8 or create user certifcates.
I find both of them not satisfying.

@followsound
Copy link

Haha, yep I've gone with user certs

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2018
@ilavender
Copy link

ilavender commented Nov 6, 2018 via email

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 6, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

8 participants