Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kops update cluster command shows "resources to be modified" for ELB SSL certs, even after creating the resources #6109

Closed
deevyea opened this issue Nov 21, 2018 · 6 comments

Comments

@deevyea
Copy link

deevyea commented Nov 21, 2018

1. What kops version are you running? The command kops version, will display
this information.

Version 1.10.0

2. What Kubernetes version are you running? kubectl version will print the
version if a cluster is running or provide the Kubernetes version specified as
a kops flag.

latest

3. What cloud provider are you using?
aws

4. What commands did you run? What is the simplest way to reproduce this issue?

  • kops edit cluster
  • Add api load balancer sslCertificate
api:
    loadBalancer:
      sslCertificate: arn:aws:acm:ap-southeast-2:xxxxxxxxx:certificate/xxxxxxxxxxxxxx
      type: Public

5. What happened after the commands executed?

  • kops update cluster
kops update cluster
I1121 23:24:39.725294   26837 executor.go:103] Tasks: 0 done / 92 total; 37 can run
I1121 23:24:40.565978   26837 executor.go:103] Tasks: 37 done / 92 total; 28 can run
I1121 23:24:41.260946   26837 executor.go:103] Tasks: 65 done / 92 total; 19 can run
I1121 23:24:42.093260   26837 executor.go:103] Tasks: 84 done / 92 total; 5 can run
I1121 23:24:42.326154   26837 dnsname.go:111] AliasTarget for "api.kubecluster.xxxxxxxxxxxxxxxxxx." is "api-kubeclusterxxxxxxxxxxxxxxxxxx."
I1121 23:24:42.471991   26837 executor.go:103] Tasks: 89 done / 92 total; 3 can run
I1121 23:24:42.562422   26837 executor.go:103] Tasks: 92 done / 92 total; 0 can run
Will modify resources:
  LoadBalancer/api.kubecluster.xxxxxxxxxxxxxxxxxx
  	Listeners           	 {443: {"InstancePort":443,"SSLCertificateID":""}} -> {443: {"InstancePort":443,"SSLCertificateID":"arn:aws:acm:ap-southeast-2:xxxxxxxxxx:certificate/xxxxxxxxxxxxxxxxxx"}}
  • kops update cluster --yes
  • kops rolling-update cluster --force --yes

6. What did you expect to happen?
kops update cluster --yes to modify the resources.

The certificate gets added in to the ELB and API server works fine with this certificate. However I see the below output everytime I run "kops update cluster"

Will modify resources:
  LoadBalancer/api.kubecluster.xxxxxxxxxxxxxxxxxx
  	Listeners           	 {443: {"InstancePort":443,"SSLCertificateID":""}} -> {443: {"InstancePort":443,"SSLCertificateID":"arn:aws:acm:ap-southeast-2:xxxxxxxxxx:certificate/xxxxxxxxxxxxxxxxxx"}}

Would you be able to fix this bug?

@deevyea deevyea changed the title Kops update cluster command shows "resources to be modified" for ELB resources Kops update cluster command shows "resources to be modified" for ELB SSL certs, even after creating the resources Nov 21, 2018
@rifelpet
Copy link
Member

This bug was fixed in #5814 and will be a part of the upcoming 1.11.0 release

@deevyea
Copy link
Author

deevyea commented Dec 11, 2018

@rifelpet Thanks for replying. But I see this issue even after the upgrade to 1.11.5.

@rifelpet
Copy link
Member

Apologies for the ambiguity. It’ll be fixed in the next stable release of Kops, not Kubernetes.

@deevyea
Copy link
Author

deevyea commented Dec 12, 2018

@rifelpet .Thanks for the reply. Cheers!

@rifelpet
Copy link
Member

Cheers!

/close

@k8s-ci-robot
Copy link
Contributor

@rifelpet: Closing this issue.

In response to this:

Cheers!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants