Fixes spurious LoadBalancer change when using ACM Certificate #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `.spec.api.loadBalancer.sslCertificate`, subsequent `kops update cluster` report the following spurious change:
```
Will modify resources:
LoadBalancer/api.ho-prod-a.us-east-1.k8s.tune.com
Listeners {443: {"InstancePort":443,"SSLCertificateID":""}} -> {443: {"InstancePort":443,"SSLCertificateID":"arn:aws:acm:us-east-1:000000000000:certificate/..."}}
```
This is because we werent keeping track of the ACM Certificate when describing the "actual" load balancer status.
This fixes that behavior, and now kops accurately reports no changes to be made.
k8s-ci-robot
added
the
size/XS
k8s-ci-robot
added
the
cncf-cla: yes
|
/retest |
|
Thanks @rifelpet ! /lgtm |
k8s-ci-robot
added
the
lgtm
|
Thank so much @rifelpet! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mikesplain, rdrgmnzs, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thank you so much @rifelpet ❤️ , I missed that while implementing the ACM integration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
.spec.api.loadBalancer.sslCertificate, subsequentkops update clusterreport the following spurious change after the certificate has already been attached to the listener:This is because we werent keeping track of the ACM Certificate when describing the "actual" load balancer status.
This fixes that behavior, and now kops accurately reports no changes to be made. I also confirmed that
update clustercontinues to work on clusters that dont specify ansslCertificate.