-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for KubeAPIServer --request-timeout flag #10038
Add support for KubeAPIServer --request-timeout flag #10038
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @dntosas! |
Hi @dntosas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-cla |
d5c0e34
to
77c02d4
Compare
a175856
to
7761860
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @dntosas. Should be a pretty useful option.
I added a few comments, mostly nits.
/ok-to-test
7761860
to
e5a930a
Compare
In this commit, we initialize the support of --request-timeout flag on the configuration of KubeAPIServer so as to enable users for setting timeout duration value for all kinds of handlers. Signed-off-by: dntosas <ntosas@gmail.com>
e5a930a
to
66f42d8
Compare
Thanks @dntosas ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dntosas, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks for the comments @hakman and have a nice sunday! qq: tried a manual testing by cherry-picking this commit on |
@dntosas for this to work you need a full build, including nodeup. If you want cherrypick to 1.18, please do it using the ckerry-pick script from the kubernetes repo. If you do it soon it may be included in next build. |
…-upstream-release-1.18 Automated cherry pick of #10038: Add support for KubeAPIServer --request-timeout flag
What type of PR is this?
/kind api-change
What this PR does / why we need it:
Add support for kops to declare
--request-timeout
flag from kube-apiserverWhich issue(s) this PR fixes:
Addresses #10026
Does this PR introduce a user-facing change?:
Enable users to set timeout value for all kinds of handlers via
request-timeout
flag on kube-apiserverAdditional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: