Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for KubeAPIServer --request-timeout flag #10038

Merged

Conversation

dntosas
Copy link
Contributor

@dntosas dntosas commented Oct 10, 2020

What type of PR is this?
/kind api-change

What this PR does / why we need it:
Add support for kops to declare --request-timeout flag from kube-apiserver

Which issue(s) this PR fixes:
Addresses #10026

Does this PR introduce a user-facing change?:

Enable users to set timeout value for all kinds of handlers via request-timeout flag on kube-apiserver

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

kind: Cluster
spec:
    kubeAPIServer:
      requestTimeout: "180s"

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 10, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @dntosas!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @dntosas. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2020
@k8s-ci-robot k8s-ci-robot added area/api size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/documentation labels Oct 10, 2020
@dntosas
Copy link
Contributor Author

dntosas commented Oct 10, 2020

/retest-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 10, 2020
@dntosas dntosas force-pushed the apiserver-include-reqTimeout-conf branch from d5c0e34 to 77c02d4 Compare October 10, 2020 17:00
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 10, 2020
@dntosas dntosas force-pushed the apiserver-include-reqTimeout-conf branch 5 times, most recently from a175856 to 7761860 Compare October 10, 2020 19:04
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this @dntosas. Should be a pretty useful option.
I added a few comments, mostly nits.
/ok-to-test

pkg/apis/kops/componentconfig.go Outdated Show resolved Hide resolved
pkg/apis/kops/v1alpha2/componentconfig.go Outdated Show resolved Hide resolved
docs/cluster_spec.md Outdated Show resolved Hide resolved
docs/cluster_spec.md Outdated Show resolved Hide resolved
docs/cluster_spec.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2020
@hakman hakman changed the title Enable KubeAPIServer --request-timeout flag Add support for KubeAPIServer --request-timeout flag Oct 11, 2020
@dntosas dntosas force-pushed the apiserver-include-reqTimeout-conf branch from 7761860 to e5a930a Compare October 11, 2020 11:10
In this commit, we initialize the support of --request-timeout flag on
the configuration of KubeAPIServer so as to enable users for setting
timeout duration value for all kinds of handlers.

Signed-off-by: dntosas <ntosas@gmail.com>
@dntosas dntosas force-pushed the apiserver-include-reqTimeout-conf branch from e5a930a to 66f42d8 Compare October 11, 2020 11:17
@hakman
Copy link
Member

hakman commented Oct 11, 2020

Thanks @dntosas !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dntosas, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2020
@dntosas
Copy link
Contributor Author

dntosas commented Oct 11, 2020

Thanks for adding this @dntosas. Should be a pretty useful option.
I added a few comments, mostly nits.
/ok-to-test

thanks for the comments @hakman and have a nice sunday!

qq: tried a manual testing by cherry-picking this commit on release-1.18 branch and build kops binary from there. what observed, is that although kops does actually update cluster.yaml on remote state and forces a master node rotation, api-server still starts with the default value of request-timeout rather than specified one ^^ maybe we miss something in this commit that prevent actual mapping from happening? still searching for this

@k8s-ci-robot k8s-ci-robot merged commit 5266619 into kubernetes:master Oct 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 11, 2020
@hakman
Copy link
Member

hakman commented Oct 11, 2020

@dntosas for this to work you need a full build, including nodeup.

If you want cherrypick to 1.18, please do it using the ckerry-pick script from the kubernetes repo. If you do it soon it may be included in next build.

k8s-ci-robot added a commit that referenced this pull request Oct 11, 2020
…-upstream-release-1.18

Automated cherry pick of #10038: Add support for KubeAPIServer --request-timeout flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants